SafeArgs gradle plugin is creating tasks eagerly [260322841]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Nov 24, 2022 10:01PM

Component used: Navigation Version used: 2.5.2 Devices/Android versions reproduced on: N/A

Seems Navigation SafeArgs gradle plugin is not utilizing the task configuration avoidance API provided by gradle. In other words the generateSafeArgs<Variant> tasks are created eagerly if they're actually not being executed.

Seems this line is the culprit here https://android.googlesource.com/platform/frameworks/support/+blame/refs/heads/androidx-main/navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt#109

Comments

il...@google.com <il...@google.com> May 12, 2023 07:37PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Aug 22, 2023 07:34PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jb...@google.com <jb...@google.com> #3Aug 22, 2023 07:35PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

pr...@google.com <pr...@google.com> #4Sep 6, 2023 07:55PM

deleted

na...@google.com <na...@google.com> #5Jan 24, 2024 07:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

Issue 260322841