SafeArgs gradle plugin is creating tasks eagerly [260322841]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Nov 24, 2022 10:01PM

Component used: Navigation Version used: 2.5.2 Devices/Android versions reproduced on: N/A

Seems Navigation SafeArgs gradle plugin is not utilizing the task configuration avoidance API provided by gradle. In other words the generateSafeArgs<Variant> tasks are created eagerly if they're actually not being executed.

Seems this line is the culprit here https://android.googlesource.com/platform/frameworks/support/+blame/refs/heads/androidx-main/navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt#109

Comments

il...@google.com <il...@google.com> May 12, 2023 07:37PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Aug 22, 2023 07:34PM

since these are in public API (:/) we need to do this in 1.2

jb...@google.com <jb...@google.com> #3Aug 22, 2023 07:35PM

Marked as fixed.

since it is already marked as deprecated, we can probably do it by now.

pr...@google.com <pr...@google.com> #4Sep 6, 2023 07:55PM

Opening diff shortly

na...@google.com <na...@google.com> #5Jan 24, 2024 07:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

Issue 260322841