SafeArgs gradle plugin is creating tasks eagerly [260322841]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Nov 24, 2022 10:01PM

Component used: Navigation Version used: 2.5.2 Devices/Android versions reproduced on: N/A

Seems Navigation SafeArgs gradle plugin is not utilizing the task configuration avoidance API provided by gradle. In other words the generateSafeArgs<Variant> tasks are created eagerly if they're actually not being executed.

Seems this line is the culprit here https://android.googlesource.com/platform/frameworks/support/+blame/refs/heads/androidx-main/navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt#109

Comments

il...@google.com <il...@google.com> May 12, 2023 07:37PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Aug 22, 2023 07:34PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

jb...@google.com <jb...@google.com> #3Aug 22, 2023 07:35PM

Marked as fixed.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

pr...@google.com <pr...@google.com> #4Sep 6, 2023 07:55PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

na...@google.com <na...@google.com> #5Jan 24, 2024 07:52PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

Issue 260322841