Status Update
Comments
ys...@google.com <ys...@google.com> #2
Good catch!
Possibly relevant
ys...@google.com <ys...@google.com> #3
Curious, is it intended that TimeText could have an interact-able composable? Like a Network symbol in leadingCurvedContent that shows network information when clicked?
ys...@google.com <ys...@google.com> #4
In the last patch (going out as alpha19) we removed that, since CurvedText is not a compose-ui node anymore, but we will look into adding it back again (with better bounds).
ys...@google.com <ys...@google.com> #5
Branch: androidx-main
commit 29737ba91ffe21e7b3132693094b5484c5cecbe1
Author: Sergio Sancho <ssancho@google.com>
Date: Mon Oct 03 14:18:01 2022
Create compose-ui nodes for curved text elements.
For each curvedText/basicCurvedText we create a compose-ui node that has
as content description the text of the (basic)curved text, and we size
and place it appropiatelly. This enables talkback to work properly with
curved text elements.
Minor change to the internal API for CurvedChild.initializeMeasure
Test: Manual, with and withouth talkback. + ./gradlew :wear:compose:compose-foundation:connectedCheck
Relnote: "curveText and basicCurvedText will now have a properly sized
and placed (but empty) compose-ui node associated with them, using the text as
content description, to properly work with talkback"
Bug: 210721259
Change-Id: I7af7ced923180839eee782fe2e45a1976c7e8ab4
M wear/compose/compose-foundation/samples/src/main/java/androidx/wear/compose/foundation/samples/CurvedWorldSample.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedLayout.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedContainer.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedSize.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/BasicCurvedText.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedPadding.kt
M wear/compose/compose-foundation/src/androidAndroidTest/kotlin/androidx/wear/compose/foundation/SpyModifier.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedComposable.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/FoundationDemos.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedModifier.kt
ys...@google.com <ys...@google.com> #6
The following release(s) address this bug:
androidx.wear.compose:compose-foundation:1.1.0-beta01
jn...@google.com <jn...@google.com>
ys...@google.com <ys...@google.com> #7
Internally it has been commented that the right fix is probably for the existing rememberPlaceholderState to use rememberUpdatedState for the lambda.
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit a08d3c02b5babbf8587bb1498009b6f64e624e81
Author: John Nichol <jnichol@google.com>
Date: Fri Dec 02 12:12:33 2022
Update PlaceholderState to ensure that the state is updated if the onContentReady() lambda changes.
Update PlaceholderState to take a State<() -> Boolean> for the isContentReady lambda and update rememberPlaceholderState so that the lambda is wrapped in rememberUpdatedState so that the state will be updated if the lambda changes.
Bug: 260343754
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
Relnote: "PlaceholderState.rememberPlaceholderState() updated to use rememberUpdatedState to that the state will update if the onContentReady lambda."
Change-Id: I02635c21c723a91aa2f5915fe79468a463fd1698
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/MaterialTest.kt
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/PlaceholderTest.kt
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/ScalingLazyListLayoutInfoTest.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Placeholder.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/PlaceholderDemo.kt
jn...@google.com <jn...@google.com>
na...@google.com <na...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.2.0-alpha02
androidx.wear.compose:compose-material:1.1.1
na...@google.com <na...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.4.0-rc01
Description
Version used: 1.1.0-rc01
Devices/Android versions reproduced on: Emulator / Android Studio Previews
Repro
Expected placeholder and content states
Actual final content state