NonConstantResourceId lint rule cannot detect to assign constant values from resource id [260752253]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Nov 30, 2022 04:44AM

DESCRIBE THE ISSUE IN DETAIL:

android.nonFinalResIds property will be enabled by default since AGP 8.0
And lint checker provides NonConstantResourceId rule to prepare behavior changes.
But NonConstantResourceId rule does not warning about constant value assign from resource ids.

STEPS TO REPRODUCE:

git clone https://github.com/ganadist/VersionCodeDemo -b nonFinalResIdReport

cd VersionCodeDemo

./gradlew :app:lintDevelopDebug

Expected Result :
When android.nonFinalResIds is enabled, kotlin compiler raised error.

echo android.nonFinalResIds=true >> gradle.properties

./gradlew :app:assembleDevelopDebug

> Task :app:compileDevelopDebugKotlin FAILED
e: app/src/main/java/com/example/myapplication/MainActivity.kt: (15, 27): Const 'val' initializer should be a constant value
> Task :app:compileDevelopDebugJavaWithJavac FAILED
app/src/main/java/com/example/myapplication/SubActivity.java:13: error: constant expression required
            case R.id.text: {
                     ^
app/src/main/java/com/example/myapplication/SubActivity.java:16: error: constant expression required
            case R.id.bottom: {

So, lint check result should be

app/src/main/java/com/example/myapplication/MainActivity.kt:15: Warning: Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them in switch case statements [NonConstantResourceId]
        val resId = R.id.text
        ~~~~~~~~~
app/src/main/java/com/example/myapplication/SubActivity.java:13: Warning: Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them in switch case statements [NonConstantResourceId]
            case R.id.text: {
                 ~~~~~~~~~
app/src/main/java/com/example/myapplication/SubActivity.java:16: Warning: Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them in switch case statements [NonConstantResourceId]
            case R.id.bottom: {
                 ~~~~~~~~~~~

   Explanation for issues of type "NonConstantResourceId":
   Avoid the usage of resource IDs where constant expressions are required.

   A future version of the Android Gradle Plugin will generate R classes with
   non-constant IDs in order to improve the performance of incremental
   compilation.

Actual result : NonConstantResourceId rule does not show warning about constants value assign from resource Ids.

app/src/main/java/com/example/myapplication/SubActivity.java:13: Warning: Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them in switch case statements [NonConstantResourceId]
            case R.id.text: {
                 ~~~~~~~~~
app/src/main/java/com/example/myapplication/SubActivity.java:16: Warning: Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them in switch case statements [NonConstantResourceId]
            case R.id.bottom: {
                 ~~~~~~~~~~~

   Explanation for issues of type "NonConstantResourceId":
   Avoid the usage of resource IDs where constant expressions are required.

   A future version of the Android Gradle Plugin will generate R classes with
   non-constant IDs in order to improve the performance of incremental
   compilation.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: 2021.3.1 Version of Gradle Plugin: 7.3.1
Version of Gradle: 7.5
Version of Java: OpenJDK 11/17
OS: Any

Comments

ac...@google.com <ac...@google.com> Nov 30, 2022 06:25AM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> Nov 30, 2022 05:46PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #2Nov 30, 2022 08:51PM

Marked as fixed.

Will be this fix also part of 4.2 please?

ga...@linecorp.com <ga...@linecorp.com> #3Dec 1, 2022 02:21AM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

tn...@google.com <tn...@google.com> #4Dec 1, 2022 05:41AM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

Issue 260752253