ComponentDialog should also implement SavedStateRegistryOwner [261162296]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Dec 2, 2022 11:15PM

Component used: Activity

Version used: 1.7.0-alpha02

It would be really convenient if ComponentDialog, in addition to implementing LifecycleOwner and OnBackPressedDispatcherOwner, would also implement SavedStateRegistryOwner.

That SavedStateRegistryOwner should be plugged into the Dialog class' onSaveInstanceState and onRestoreInstanceState.

This would make it much easier to use Jetpack Compose in a ComponentDialog, since Jetpack Compose requires both a LifecycleOwner and a SavedStateRegistryOwner attached to the Window via the ViewTree APIs.

Comments

sa...@google.com <sa...@google.com> Dec 6, 2022 08:47PM

Assigned to sa...@google.com.

za...@affirm.com <za...@affirm.com> #2Dec 6, 2022 09:07PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

sa...@google.com <sa...@google.com> Dec 8, 2022 03:16AM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #3Dec 15, 2022 04:41PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4Jan 4, 2023 01:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit ef85e7e7f4e5742d9668f98c15be6b214b00e6f9
Author: sanura <sanura@google.com>
Date: Wed Jan 04 00:00:32 2023

Have ComponentDialog also set ViewTreeSavedStateRegistryOwner

Now that ComponentDialog is a SavedStateRegistryOwner,
it should also set it during its ViewTree initialization.

RelNote: "`ComponentDialog` now also sets the
`SavedStateRegistryOwner` for its ViewTree."
Bug: 261162296
Test: testViewTreeSavedStateRegistryOwner

Change-Id: I7346856b333933e03f5d3b0d380f5122b4856908

M activity/activity/src/androidTest/java/androidx/activity/ComponentDialogTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt

https://android-review.googlesource.com/2374989

za...@affirm.com <za...@affirm.com> #5Jan 4, 2023 04:48PM

Great to see the progress on this! Just curious, in the other bug I linked I noted that AppcompatDialog which inherits from ComponentDialog doesn't call some methods on super which would trigger this new code, instead AppcompatDialog calls some delegate methods which don't reach ComponentDialog. Will that be addressed as well?

sa...@google.com <sa...@google.com> #6Jan 4, 2023 11:46PM

Marked as fixed.

re #5: Please use the other bug (https://b.corp.google.com/issues/261314581) for questions regarding AppCompat since it will better help others follow along with this discussion.

za...@affirm.com <za...@affirm.com> #7Jan 5, 2023 12:59AM

Ah dang I am not a google employee so can't see that bug.

il...@google.com <il...@google.com> #8Jan 5, 2023 01:08AM

It is the same bug as you mentioned in comment#2 - note the number is exactly the same :)

sa...@google.com <sa...@google.com> #9Jan 5, 2023 07:51PM

My apologies. Public link is https://issuetracker.google.com/issues/261314581

na...@google.com <na...@google.com> #10Jan 11, 2023 08:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.activity:activity:1.7.0-alpha03