Fixed
Status Update
No update yet.
Comments
ap...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ap...@google.com
yea i'll take it.
jb...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
pr...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
Description
DialogFragmentNavigatordoes not currently use the newNavigatorAPIs (i.e. push/popWithTransition). As a result theNavBackStackEntrys associated with theDialogFragmentall changeLifecycle.Stateimmediately instead of in sync with theDialogFragment.This can create problems, for example if a user attempted to access the
ViewModelof theirNavBackStackEntryas the Dialog was being dismissed, but before it was destroyed, Navigation would crash stating that the entry is not available. It should still be there until the Dialog is actually destroyed.