ComponentDialog does not properly set ViewTreeLifeCycleOnwer [261314581]

Fixed

Bug

Status Update

No update yet.

Description

za...@affirm.com

created issue #1

Dec 4, 2022 07:03PM

Component used: AppCompatDialog/ComponentDialog
Version used: 1.5.1 (also tested on 1.7.0-alpha01)
Devices/Android versions reproduced on: Pixel 5 API 30 emulator

Description:
The linked repo or ZIP contains a reproduction of an issue with the AppCompatDialog & Componentdialog. It shows that the ComponentDialog does not set the ViewLifecycleTreeOwner correctly when setContentView is called. AppCompatDialog (the subclass of ComponentDialog) does not call super.setContentView and instead calls a delegate which never reaches ComponentDialog. When trying to access the ViewTreeLifecycleOwner of the dialog, a null pointer exception is thrown.

If this is a bug in the library, we would appreciate if you could attach:
-

https://github.com/zsperske/ViewTreeLifecycleOwnerDialogBug
- ZIP also attached

ViewTreeLifeCycleOwnerBug.zip

21 MB

Download

Comments

il...@google.com <il...@google.com> Dec 5, 2022 06:27AM

Reassigned to jb...@google.com.

sa...@google.com <sa...@google.com> Dec 7, 2022 09:51PM

Reassigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 16, 2023 02:01AM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #2Mar 16, 2023 10:27PM

Please upload a sample project that recreates this issue.

ap...@google.com <ap...@google.com> #3Mar 21, 2023 09:48PM

Here is the sample project: https://github.com/willflier/exception-report

sa...@google.com <sa...@google.com> Mar 22, 2023 06:39PM

Marked as fixed.

jb...@google.com <jb...@google.com> #4Mar 29, 2023 11:35PM

Upload it for direct download

na...@google.com <na...@google.com> #5Jul 26, 2023 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2e36de7a65cbbf0ff7d81d82842b0e4836629819
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Aug 18 14:34:35 2021

Fix indexOutOfBounds error for setGraph

For for loop in setGraph is currently attempting to access the array out
of bounds. It only fails when using 13 or 29 destinations in the graph.

RelNote: "There will no longer be an `ArrayIndexOutOfBoundsException`
when calling `setGraph` with a graph with 13 or 29 destinations."
Test: add navControllerRouteTest
Bug: 195171984

Change-Id: I1a9f17c4616bc38dd3dd89cb1da29814c3dfd512

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1801108

co...@gmail.com <co...@gmail.com> #6Jul 27, 2023 01:08AM

This has been fixed internally and will be available in the Navigation 2.4.0-alpha08 release.