ComponentDialog does not properly set ViewTreeLifeCycleOnwer [261314581]

Fixed

Bug

Status Update

No update yet.

Description

za...@affirm.com

created issue #1

Dec 4, 2022 07:03PM

Component used: AppCompatDialog/ComponentDialog
Version used: 1.5.1 (also tested on 1.7.0-alpha01)
Devices/Android versions reproduced on: Pixel 5 API 30 emulator

Description:
The linked repo or ZIP contains a reproduction of an issue with the AppCompatDialog & Componentdialog. It shows that the ComponentDialog does not set the ViewLifecycleTreeOwner correctly when setContentView is called. AppCompatDialog (the subclass of ComponentDialog) does not call super.setContentView and instead calls a delegate which never reaches ComponentDialog. When trying to access the ViewTreeLifecycleOwner of the dialog, a null pointer exception is thrown.

If this is a bug in the library, we would appreciate if you could attach:
-

https://github.com/zsperske/ViewTreeLifecycleOwnerDialogBug
- ZIP also attached

ViewTreeLifeCycleOwnerBug.zip

21 MB

Download

Comments

il...@google.com <il...@google.com> Dec 5, 2022 06:27AM

Reassigned to jb...@google.com.

sa...@google.com <sa...@google.com> Dec 7, 2022 09:51PM

Reassigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 16, 2023 02:01AM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #2Mar 16, 2023 10:27PM

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

ap...@google.com <ap...@google.com> #3Mar 21, 2023 09:48PM

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

sa...@google.com <sa...@google.com> Mar 22, 2023 06:39PM

Marked as fixed.

jb...@google.com <jb...@google.com> #4Mar 29, 2023 11:35PM

I also can't give parameters to the fragment being inflated.

na...@google.com <na...@google.com> #5Jul 26, 2023 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

co...@gmail.com <co...@gmail.com> #6Jul 27, 2023 01:08AM

Hey, Thanks to checking this out, I just checked this sample in the the repository, but this does not solve my issue.

I don't have access to the actual fragment class, we use an abstraction that just returns me a instance of Fragment with the arguments set, so this won't solve the issue for me, would it be possible to allow passing the Fragment instance ?