ComponentDialog does not properly set ViewTreeLifeCycleOnwer [261314581]

Fixed

Bug

Status Update

No update yet.

Description

za...@affirm.com

created issue #1

Dec 4, 2022 07:03PM

Component used: AppCompatDialog/ComponentDialog
Version used: 1.5.1 (also tested on 1.7.0-alpha01)
Devices/Android versions reproduced on: Pixel 5 API 30 emulator

Description:
The linked repo or ZIP contains a reproduction of an issue with the AppCompatDialog & Componentdialog. It shows that the ComponentDialog does not set the ViewLifecycleTreeOwner correctly when setContentView is called. AppCompatDialog (the subclass of ComponentDialog) does not call super.setContentView and instead calls a delegate which never reaches ComponentDialog. When trying to access the ViewTreeLifecycleOwner of the dialog, a null pointer exception is thrown.

If this is a bug in the library, we would appreciate if you could attach:
-

https://github.com/zsperske/ViewTreeLifecycleOwnerDialogBug
- ZIP also attached

ViewTreeLifeCycleOwnerBug.zip

21 MB

Download

Comments

il...@google.com <il...@google.com> Dec 5, 2022 06:27AM

Reassigned to jb...@google.com.

sa...@google.com <sa...@google.com> Dec 7, 2022 09:51PM

Reassigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 16, 2023 02:01AM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #2Mar 16, 2023 10:27PM

Alternatively, we could make all of the drawable compat classes public.

ap...@google.com <ap...@google.com> #3Mar 21, 2023 09:48PM

Needs to wait until we're back to alpha.

Bugjuggler: wait until 2022-07-21

sa...@google.com <sa...@google.com> Mar 22, 2023 06:39PM

Marked as fixed.

jb...@google.com <jb...@google.com> #4Mar 29, 2023 11:35PM

Hi. I've received your bug and will wait until 2022-07-21 00:00 -0400 EDT and then assign the bug to alanv@google.com.

na...@google.com <na...@google.com> #5Jul 26, 2023 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit de70044326e54d6a50f0745f481bd46927cb777a
Author: Alan Viverette <alanv@google.com>
Date: Thu Jul 28 13:03:36 2022

Move AppCompat's drawable compat classes to public API

Nullability is missing because the platform classes are also missing
nullability.

Relnote: "Move DrawableWrapper, DrawableContainer, and StateListDrawable
compat classes to public API."
Fixes: 227789566
Test: DrawableContainerCompatTest, AnimatedStateListDrawableCompatTest
Change-Id: I37f3e188d926628853c3ef37ce7a32f28afd2823

A appcompat/appcompat-resources/api/restricted_current.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableWrapperCompat.java
M appcompat/appcompat-resources/lint-baseline.xml
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableContainerCompat.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/AnimatedStateListDrawableCompat.java
M appcompat/appcompat-resources/api/api_lint.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/StateListDrawableCompat.java
M appcompat/appcompat-resources/src/androidTest/java/androidx/appcompat/graphics/drawable/DrawableContainerCompatTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat-resources/api/public_plus_experimental_current.txt
M appcompat/appcompat-resources/api/current.txt
M appcompat/appcompat-resources/api/restricted_current.txt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java

https://android-review.googlesource.com/2120177

co...@gmail.com <co...@gmail.com> #6Jul 27, 2023 01:08AM

deleted