AGP 7.4.0-rc01 breaks Variant API with "Querying the mapped value of map(provider(java.util.Set)) before task '...' has completed is not supported" [261329823]

Fixed

Bug

Status Update

No update yet.

Description

nc...@meta.com

created issue #1

Dec 5, 2022 01:43PM

This bug should be moved under:
> Android Public Tracker > App Development > Android Studio > Gradle > Android Gradle Plugin
but I don't have permission to do so.

## Expected Result

AGP Variant API works well between 7.4.0-beta05 and 7.4.0-rc01

## Observed Results

Bumping AGP from 7.4.0-beta05 to 7.4.0-rc01 results in a build failure with the following message:

```
> Task :example:mapDebugSourceSetPaths FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':example:mapDebugSourceSetPaths'.
> Querying the mapped value of map(provider(java.util.Set)) before task ':example:reproducerdebugTask' has completed is not supported
```

It seems like AGP is querying the value of the `@OutputDirectory` of the task I created `example:reproducerdebugTask`.

## Reproducer

You can find a small reproducer here:

https://github.com/cortinico/reproducer-agp-74rc01

Specifically this commit shows a working setup with AGP 7.4 beta5
-

https://github.com/cortinico/reproducer-agp-74rc01/commit/89ad099f44ecbb2bed53ece979c2f1bd241fe31f

Bumping to RC01 causes the failure:
-

https://github.com/cortinico/reproducer-agp-74rc01/commit/6fc570e9492b4413a013d9031aba5ceb80f08a65

I've also configured the CI so you have a clean environment where you can easily reproduce.
The command to reproduce upon cloning is `./gradlew :example:assembleDebug`.

## Further Context

This issue was noticed upstream on React Native here:

https://github.com/facebook/react-native/pull/35522
as we're using a similar pattern inside the React Native Gradle Plugin.

Comments

vi...@google.com <vi...@google.com> Dec 5, 2022 01:50PM

Status: New

ga...@google.com <ga...@google.com> #2Dec 5, 2022 06:42PM

Assigned to je...@google.com.

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

je...@google.com <je...@google.com> Dec 5, 2022 07:32PM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #3Dec 6, 2022 05:57PM

Marked as fixed.

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

nc...@meta.com <nc...@meta.com> #4Dec 6, 2022 06:16PM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

je...@google.com <je...@google.com> #5Dec 6, 2022 06:30PM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

[Deleted User] <[Deleted User]> #6Dec 8, 2022 02:00PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

le...@gmail.com <le...@gmail.com> #7Dec 8, 2022 02:16PM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

ca...@gmail.com <ca...@gmail.com> #8Dec 15, 2022 08:14PM

thanks for the fix. if this can be backported to 4.0 that would be great

je...@google.com <je...@google.com> #9Dec 16, 2022 05:49PM

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

nc...@meta.com <nc...@meta.com> #10Dec 22, 2022 12:55PM

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

ga...@google.com <ga...@google.com> Dec 22, 2022 01:13PM

Status: Assigned (reopened)

xa...@google.com <xa...@google.com> #11Dec 22, 2022 05:11PM

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

ga...@google.com <ga...@google.com> #12Dec 23, 2022 05:28PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 4fe0ece4d3da01068bf0b63cd7a5f37d47fa6244
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:30 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77496

pe...@gmail.com <pe...@gmail.com> #13Dec 29, 2022 12:11PM

Project: r8
Branch: 4.0

commit 1e7c88c78ac0636eae649e132b862306ea416d48
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:43 2023

Version 4.0.58

Bug:

b/272725341

Change-Id: If899ee42bdf757985546807d785639e98b3360e6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77494

ro...@sentry.io <ro...@sentry.io> #14Jan 13, 2023 12:19AM

Project: r8
Branch: 4.0

commit b367460c6cab514f9c8c974f2a48e7ed862610de
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:37 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77492

Message last modified on Jan 13, 2023 12:20AM

nc...@meta.com <nc...@meta.com> #15Jan 13, 2023 12:50AM

I've backported the fix to version 4.0.58. Could you take that version for a spin to see if that solves the issues?

pe...@gmail.com <pe...@gmail.com> #16Jan 13, 2023 01:15PM

I verified the fix works. Thanks!

ha...@gmail.com <ha...@gmail.com> #17Jan 24, 2023 09:25AM

Thanks for reporting back and your help with this issue.

je...@google.com <je...@google.com> #18Jan 24, 2023 05:43PM

deleted

[Deleted User] <[Deleted User]> #19Feb 2, 2023 08:27AM

ชอบ

Message last modified on Feb 2, 2023 08:29AM

nc...@meta.com <nc...@meta.com> #20Feb 2, 2023 02:37PM

ชอบเรียนรู้

je...@google.com <je...@google.com> #21Feb 2, 2023 06:01PM

#19, I am sorry, there was a misunderstanding with the release team. they had an even more urgent fix to push which was 7.4.1 and the normal dot release that contains this fix got pushed to 7.4.2 which is looking to be couple of weeks away (still working the date with them). So sorry for the wrong info, It surprised me too.

nc...@meta.com <nc...@meta.com> #22Feb 2, 2023 06:30PM

That's confusing as the issue seems effectively fixed in 7.4.1, also in the reproducer I linked: https://github.com/cortinico/reproducer-agp-74rc01

pe...@gmail.com <pe...@gmail.com> #23Feb 2, 2023 07:06PM

I tested some more today. First I got the error like mentioned in #19 (looked like it at least), and 2 hours later it seemed to build, at least the app was deployed on the emulator.
For a workmate it also failed on his first try. We might see tomorrow.
Not sure yet, but it might be flaky now, depending on some cache or other internals.

I'll report back if I know more but it's good to know about the new target of 7.4.2. Really sad this kind of thing can't make it into a .0 release as prio 0 bug, especially since it *was* ready.
Maybe you guys can take this as a feedback and improve something, feels like it just hit a process / politics wall.

ar...@gmail.com <ar...@gmail.com> #24Mar 7, 2023 12:45PM

This still seems to be plaguing 7.4.2 as well

je...@google.com <je...@google.com> #25Mar 7, 2023 10:27PM

this might be due to a third party plugin. do you have a small project to reproduce the issue ?

can you provide a stack trace ?

ar...@gmail.com <ar...@gmail.com> #26Mar 14, 2023 05:21AM

my bad, it was due to react native dependencies, had to update those as well

Issue 261329823

Description

Issue summary

Comments

vi...@google.com <vi...@google.com> Dec 5, 2022 01:50PM

ga...@google.com <ga...@google.com> #2Dec 5, 2022 06:42PM

je...@google.com <je...@google.com> Dec 5, 2022 07:32PM

je...@google.com <je...@google.com> #3Dec 6, 2022 05:57PM

nc...@meta.com <nc...@meta.com> #4Dec 6, 2022 06:16PM

je...@google.com <je...@google.com> #5Dec 6, 2022 06:30PM

[Deleted User] <[Deleted User]> #6Dec 8, 2022 02:00PM

le...@gmail.com <le...@gmail.com> #7Dec 8, 2022 02:16PM

ca...@gmail.com <ca...@gmail.com> #8Dec 15, 2022 08:14PM

je...@google.com <je...@google.com> #9Dec 16, 2022 05:49PM

nc...@meta.com <nc...@meta.com> #10Dec 22, 2022 12:55PM

ga...@google.com <ga...@google.com> Dec 22, 2022 01:13PM

xa...@google.com <xa...@google.com> #11Dec 22, 2022 05:11PM

ga...@google.com <ga...@google.com> #12Dec 23, 2022 05:28PM

pe...@gmail.com <pe...@gmail.com> #13Dec 29, 2022 12:11PM

ro...@sentry.io <ro...@sentry.io> #14Jan 13, 2023 12:19AM

nc...@meta.com <nc...@meta.com> #15Jan 13, 2023 12:50AM

pe...@gmail.com <pe...@gmail.com> #16Jan 13, 2023 01:15PM

ha...@gmail.com <ha...@gmail.com> #17Jan 24, 2023 09:25AM

je...@google.com <je...@google.com> #18Jan 24, 2023 05:43PM

[Deleted User] <[Deleted User]> #19Feb 2, 2023 08:27AM

nc...@meta.com <nc...@meta.com> #20Feb 2, 2023 02:37PM

je...@google.com <je...@google.com> #21Feb 2, 2023 06:01PM

nc...@meta.com <nc...@meta.com> #22Feb 2, 2023 06:30PM

pe...@gmail.com <pe...@gmail.com> #23Feb 2, 2023 07:06PM

ar...@gmail.com <ar...@gmail.com> #24Mar 7, 2023 12:45PM

je...@google.com <je...@google.com> #25Mar 7, 2023 10:27PM

ar...@gmail.com <ar...@gmail.com> #26Mar 14, 2023 05:21AM

Add comment

Issue metadata