Status Update
No update yet.
Comments
vi...@google.com
ga...@google.com
je...@google.com
nc...@meta.com
for all who are looking for a solution use this:
je...@google.com
no we missed the boat for 7.4.0 release so it will most likely be 7.4.1
[Deleted User] <[Deleted User]>
Sure there is no way to slip it in to .0?
Eel is still just RC1, one would hope it can be in RC2 or RC3!
le...@gmail.com
+1 on what #6 wrote.
ca...@gmail.com
je...@google.com
The fix is a bit risky, so that's why we are prudent. I would be useful to test that it works fine in 8.0 beta1 when it comes out where the fix has already been merged.
nc...@meta.com
Hey all,
I've noticed that 7.4.0-rc02 has just been released and I was hoping this would have been fixed.
Sadly, the bug is still there.
The error message is slightly changed though:
Error message for -rc01
* What went wrong:
Execution failed for task ':example:mapDebugSourceSetPaths'.
> Querying the mapped value of map(provider(java.util.Set)) before task ':example:reproducerdebugTask' has completed is not supported
Error message for -rc02
* What went wrong:
Execution failed for task ':example:mapDebugSourceSetPaths'.
> Querying the mapped value of map(flatmap(provider(task 'reproducerdebugTask', class com.ncorti.kotlin.gradle.template.plugin.ReproducerTask))) before task ':example:reproducerdebugTask' has completed is not supported
Reproducer
I've updated the repro here with a commit that reproduces this failure:
You can see the failure on CI here:
Please let me know if I should open a different issue as this one is marked as "fixed"
ga...@google.com
xa...@google.com
We pushed RC2 without the fix because we needed to release it to validate some other more pressing issues.
The fix is pending. It's quite a large fix and we haven't fully decided whether to put it in 7.4.0 or wait to have it in 7.4.1. I believe it is in 8.0 Canary 10, so if you could try it there, that would be helpful. Ultimately though we have to also be sure if does not have other unforeseen side effects, and this may take a bit longer than we have time for (EE/7.4 are quite late and holding other releases so it's a bit tricky to handle this)
ga...@google.com
The fix landed in AGP 8.0.0-alpha10, as mentioned in #11. Updating ./gradlew :example:assembleDebug successfully.
Once it lands in AGP 7.4 we'll update this bug with the exact version info. Thanks!
pe...@gmail.com
Can't fully confirm, because it fails with another error now, because of React Native which doesn't work with it yet.
We really need this in 7.4. I don't really understand why it "missed the boat", since then 2 new RCs came out and it means many people won't be able to use 7.4 when it's release.
It's a fix for a showstopper regression. Should be tested in the wild asap.
ro...@sentry.io
Did this fix make it to the 7.4.0 stable release?
nc...@meta.com
According to
On the React Native side of things, we had to un-bump AGP to 7.3 as this was a major blocker for us. We also have to tell users to don't update Android Studio as Electric Eel was released today and it will prompt users to update => Resulting in broken builds.
pe...@gmail.com
ha...@gmail.com
Everything is jammed till then
je...@google.com
So far, it is scheduled for Feb 1st which looks likely at this point.
[Deleted User] <[Deleted User]>
The error does not seem to be fixed in 7.4.1. Can you confirm this is indeed released?
nc...@meta.com
Actually the issue looks like fixed on our end. We're bumping React Native to use AGP 7.4.1 and the addGeneratedSourceDirectory API here:
Thanks for working on this folks even if it took longer to land than expected
je...@google.com
#19, I am sorry, there was a misunderstanding with the release team. they had an even more urgent fix to push which was 7.4.1 and the normal dot release that contains this fix got pushed to 7.4.2 which is looking to be couple of weeks away (still working the date with them). So sorry for the wrong info, It surprised me too.
nc...@meta.com
That's confusing as the issue seems effectively fixed in 7.4.1, also in the reproducer I linked:
pe...@gmail.com
For a workmate it also failed on his first try. We might see tomorrow.
Not sure yet, but it might be flaky now, depending on some cache or other internals.
I'll report back if I know more but it's good to know about the new target of 7.4.2. Really sad this kind of thing can't make it into a .0 release as prio 0 bug, especially since it *was* ready.
Maybe you guys can take this as a feedback and improve something, feels like it just hit a process / politics wall.
ar...@gmail.com
je...@google.com
this might be due to a third party plugin. do you have a small project to reproduce the issue ?
can you provide a stack trace ?
Description
> Android Public Tracker > App Development > Android Studio > Gradle > Android Gradle Plugin
but I don't have permission to do so.
## Expected Result
AGP Variant API works well between 7.4.0-beta05 and 7.4.0-rc01
## Observed Results
Bumping AGP from 7.4.0-beta05 to 7.4.0-rc01 results in a build failure with the following message:
```
> Task :example:mapDebugSourceSetPaths FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':example:mapDebugSourceSetPaths'.
> Querying the mapped value of map(provider(java.util.Set)) before task ':example:reproducerdebugTask' has completed is not supported
```
It seems like AGP is querying the value of the `@OutputDirectory` of the task I created `example:reproducerdebugTask`.
## Reproducer
You can find a small reproducer here:
Specifically this commit shows a working setup with AGP 7.4 beta5
-
Bumping to RC01 causes the failure:
-
I've also configured the CI so you have a clean environment where you can easily reproduce.
The command to reproduce upon cloning is `./gradlew :example:assembleDebug`.
## Further Context
This issue was noticed upstream on React Native here:
as we're using a similar pattern inside the React Native Gradle Plugin.