Fixed
Status Update
No update yet.
Comments
jo...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0d2a344b8b47cd39343dd3ca0e495ac5494367b9
Author: Igor Demin <igor.demin@jetbrains.com>
Date: Thu Dec 01 10:38:07 2022
PlatformTextInputService. Undeprecate notifyFocusedRect
Fixeshttps://github.com/JetBrains/compose-jb/issues/2040
Fixeshttps://github.com/JetBrains/compose-jb/issues/2493
notifyFocusedRect was deprecated inhttps://android-review.googlesource.com/c/platform/frameworks/support/+/1959647
On Android, before deprecation this method was used to scroll to the focused text input.
This functionality was extracted to the text field itself, but we had another functionality on the other platforms.
On Desktop we show text input popup near text input (for some languages):
https://github.com/JetBrains/compose-jb/issues/2040#issuecomment-1333429514
I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives:
1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position
2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area.
Bug:
Change-Id: I23a0425b573a644fcc114a2b60d7bbbdaf5b04ed
Test: manual on Windows (./gradlew run1 -Pandroidx.compose.multiplatformEnabled=true), with Chinese keyboard layout
Relnote: `notifyFocusedRect` methods in `TextInputSession` and `TextInputService` are not deprecated again.
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
https://android-review.googlesource.com/2319924
Branch: androidx-main
commit 0d2a344b8b47cd39343dd3ca0e495ac5494367b9
Author: Igor Demin <igor.demin@jetbrains.com>
Date: Thu Dec 01 10:38:07 2022
PlatformTextInputService. Undeprecate notifyFocusedRect
Fixes
Fixes
notifyFocusedRect was deprecated in
On Android, before deprecation this method was used to scroll to the focused text input.
This functionality was extracted to the text field itself, but we had another functionality on the other platforms.
On Desktop we show text input popup near text input (for some languages):
I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives:
1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position
2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area.
Bug:
Change-Id: I23a0425b573a644fcc114a2b60d7bbbdaf5b04ed
Test: manual on Windows (./gradlew run1 -Pandroidx.compose.multiplatformEnabled=true), with Chinese keyboard layout
Relnote: `notifyFocusedRect` methods in `TextInputSession` and `TextInputService` are not deprecated again.
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
pr...@google.com
Zach can you help triage?
jo...@google.com
This is related to supporting InputConnection#requestCursorUpdate (
ma...@google.com
I believe this should be fixed by aosp/2647564, which is blocked on a new Robolectric release for reasons.
al...@google.com
Do we expect this to land by EOW? It's in the SLO chaselist now and very on fire.
pr...@google.com
Hi jossiwolf, is this part of alpha02?
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023
[M2] Stabilize ModalBottomSheetLayout
Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
https://android-review.googlesource.com/2852687
Branch: androidx-main
commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023
[M2] Stabilize ModalBottomSheetLayout
Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023
[M2] Stabilize BottomSheetScaffold
Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
https://android-review.googlesource.com/2852688
Branch: androidx-main
commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023
[M2] Stabilize BottomSheetScaffold
Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.7.0-alpha03androidx.compose.material:material-android:1.7.0-alpha03androidx.compose.material:material-desktop:1.7.0-alpha03
Description
The following Experimental APIs have existed for several releases.
Please consider stabilising or removing these APIs: