[Material] Experimental BottomSheet APIs [261409034]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 5, 2022 01:02PM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
e20b85901724	compose/material/material/api/public_plus_experimental_current.txt	(Calin Tataru	2020-09-07 19:50:01 +0100 531)	@androidx.compose.material.ExperimentalMaterialApi public final class ModalBottomSheetState extends androidx.compose.material.SwipeableState<androidx.compose.material.ModalBottomSheetValue> {
e20b85901724	compose/material/material/api/public_plus_experimental_current.txt	(Calin Tataru	2020-09-07 19:50:01 +0100 546)	@androidx.compose.material.ExperimentalMaterialApi public enum ModalBottomSheetValue {
4ebbce5de8b4	compose/material/material/api/public_plus_experimental_current.txt	(Calin Tataru	2020-09-10 09:10:57 +0100 157)	@androidx.compose.material.ExperimentalMaterialApi public enum BottomSheetValue {
87b3f5e2b286	compose/material/material/api/public_plus_experimental_current.txt	(Matvei Malkov	2020-10-01 14:41:59 +0300 132)	@androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Stable public final class BottomSheetScaffoldState {
87b3f5e2b286	compose/material/material/api/public_plus_experimental_current.txt	(Matvei Malkov	2020-10-01 14:41:59 +0300 142)	@androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Stable public final class BottomSheetState extends androidx.compose.material.SwipeableState<androidx.compose.material.BottomSheetValue> {
3aa5a20d039c	compose/material/material/api/public_plus_experimental_current.txt	(Aurimas Liutikas	2020-10-05 09:42:14 -0700 128)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static androidx.compose.material.BottomSheetScaffoldState rememberBottomSheetScaffoldState(optional androidx.compose.material.DrawerState drawerState
3aa5a20d039c	compose/material/material/api/public_plus_experimental_current.txt	(Aurimas Liutikas	2020-10-05 09:42:14 -0700 129)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static androidx.compose.material.BottomSheetState rememberBottomSheetState(androidx.compose.material.BottomSheetValue initialValue
3e445ba49456	compose/material/material/api/public_plus_experimental_current.txt	(Matvei Malkov	2021-02-04 19:27:05 +0000 528)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static androidx.compose.material.ModalBottomSheetState rememberModalBottomSheetState(androidx.compose.material.ModalBottomSheetValue initialValue
5790b29a7df2	compose/material/material/api/public_plus_experimental_current.txt	(Aurimas Liutikas	2021-06-22 12:29:59 -0700 127)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static void BottomSheetScaffold(kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.ColumnScope
5790b29a7df2	compose/material/material/api/public_plus_experimental_current.txt	(Aurimas Liutikas	2021-06-22 12:29:59 -0700 526)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static void ModalBottomSheetLayout(kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.ColumnScope
047c2efe097c	compose/material/material/api/public_plus_experimental_current.txt	(Jossi Wolf	2021-11-14 17:49:12 +0100 527)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static androidx.compose.material.ModalBottomSheetState rememberModalBottomSheetState(androidx.compose.material.ModalBottomSheetValue initialValue

Comments

jo...@google.com <jo...@google.com> #2Dec 5, 2022 01:17PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

pr...@google.com <pr...@google.com> #3Dec 5, 2023 06:07PM

Thanks for the report!

jo...@google.com <jo...@google.com> #4Jan 16, 2024 08:58PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ma...@google.com <ma...@google.com> #5Jan 17, 2024 11:45AM

deleted

al...@google.com <al...@google.com> #6Jan 17, 2024 06:59PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

pr...@google.com <pr...@google.com> #7Jan 29, 2024 11:12PM

Hi jossiwolf, is this part of alpha02?

ap...@google.com <ap...@google.com> #8Feb 5, 2024 04:51PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023

[M2] Stabilize ModalBottomSheetLayout

Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2852687

ap...@google.com <ap...@google.com> #9Feb 5, 2024 04:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023

[M2] Stabilize BottomSheetScaffold

Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2852688

pr...@google.com <pr...@google.com> #10Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha03
androidx.compose.material:material-android:1.7.0-alpha03
androidx.compose.material:material-desktop:1.7.0-alpha03