Experimental clickabChip APIs [261424370]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 5, 2022 02:47PM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
8a96ec7c2119	compose/material/material/api/public_plus_experimental_current.txt	(Connie Shi	2021-11-28 11:29:00 -0500 227)	@androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Stable public interface ChipColors {
8a96ec7c2119	compose/material/material/api/public_plus_experimental_current.txt	(Connie Shi	2021-11-28 11:29:00 -0500 233)	@androidx.compose.material.ExperimentalMaterialApi public final class ChipDefaults {
8a96ec7c2119	compose/material/material/api/public_plus_experimental_current.txt	(Connie Shi	2021-11-28 11:29:00 -0500 255)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static void Chip(kotlin.jvm.functions.Function0<kotlin.Unit> onClick
6e3ec4f266c2	compose/material/material/api/public_plus_experimental_current.txt	(Connie Shi	2022-01-14 13:08:39 -0500 256)	method @androidx.compose.material.ExperimentalMaterialApi @androidx.compose.runtime.Composable public static void FilterChip(boolean selected
6e3ec4f266c2	compose/material/material/api/public_plus_experimental_current.txt	(Connie Shi	2022-01-14 13:08:39 -0500 625)	@androidx.compose.material.ExperimentalMaterialApi public interface SelectableChipColors {
987ce856d346		(Shalom Gibly	2022-03-10 13:49:19 -0800 388)	@androidx.compose.material3.ExperimentalMaterial3Api public final class FilterChipDefaults {
987ce856d346		(Shalom Gibly	2022-03-10 13:49:19 -0800 793)	@androidx.compose.material3.ExperimentalMaterial3Api public final class SuggestionChipDefaults {
1a26c8705a0c		(Shalom Gibly	2022-03-21 21:55:23 -0700 43)	@androidx.compose.material3.ExperimentalMaterial3Api public final class AssistChipDefaults {
1a26c8705a0c		(Shalom Gibly	2022-03-21 21:55:23 -0700 477)	@androidx.compose.material3.ExperimentalMaterial3Api public final class InputChipDefaults {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 185)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class ChipBorder {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 188)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class ChipColors {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 191)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class ChipElevation {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 492)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class ListItemColors {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 658)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class SelectableChipBorder {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 661)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class SelectableChipColors {
071c483c7223		(Connie Shi	2022-07-12 19:09:26 -0400 664)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Immutable public final class SelectableChipElevation {
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 195)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void AssistChip(kotlin.jvm.functions.Function0<kotlin.Unit> onClick
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 196)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void ElevatedAssistChip(kotlin.jvm.functions.Function0<kotlin.Unit> onClick
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 197)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void ElevatedFilterChip(boolean selected
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 198)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void ElevatedSuggestionChip(kotlin.jvm.functions.Function0<kotlin.Unit> onClick
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 199)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void FilterChip(boolean selected
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 200)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void InputChip(boolean selected
34705961d79d		(Connie Shi	2022-08-04 20:26:44 -0400 201)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void SuggestionChip(kotlin.jvm.functions.Function0<kotlin.Unit> onClick

Comments

co...@google.com <co...@google.com> #2Dec 13, 2022 07:49PM

The clickable chips are good candidates for promotion. The selectable ones need to stay until we figure out how to smoothly animate between selected & unselected states

co...@google.com <co...@google.com> Jan 30, 2023 08:44PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #3Jan 31, 2023 03:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1824be950000b94e98dc0030182d7c959413f6b1
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 30 13:23:17 2023

Removed experiemental tag from assist chip and suggestion chip APIs.

Bug:

b/261424370

Test: Ran existing tests
Relnote: "Stablize the APIs for assist chip and suggestion chip"
Change-Id: Ibb67b1b2a21c8cb37213a22a76d49357b4097621

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/ChipSamples.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Chip.kt

https://android-review.googlesource.com/2407752

co...@google.com <co...@google.com> #4Jan 31, 2023 03:41PM

The clickable chips have been promoted to stable, the selectable chips will remain in experimental until we figure out how to smoothly animate between selected & unselected states.

co...@google.com <co...@google.com> #5Jan 31, 2023 09:08PM

Marked as fixed.

Renamed this bug to focus on clickable chip apis, separated out the selectable chip related APIs into b/267348606

ap...@google.com <ap...@google.com> #6Feb 1, 2023 07:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit ebb4bfe377ff59300d09287c03898ba8a2843b24
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 30 17:53:51 2023

Removed experiemental tag from the show snackbar API.

Bug:

b/261424370

Test: Ran existing tests
Relnote: "Stablize the API `showSnackbar`"
Change-Id: I195c2c308e2597acf97dc90b5c0f3315b3556e90

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SnackbarHost.kt

https://android-review.googlesource.com/2411212

pr...@google.com <pr...@google.com> #7Feb 8, 2023 06:22PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.annotation:annotation-jvm:1.6.0-rc01
androidx.compose.material3:material3:1.1.0-alpha06