IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support
Branch: androidx-main

commit 4e43a0b7fc91fb2206ac20c37c770f3a797e6062
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Dec 06 13:59:38 2022

    Promote GoogleFont to stable API
   
    Relnote: "GoogleFont is now stable API."
    Test: n/a
    Bug: b/261435386
    Change-Id: Ic90b0bcd8fa3901cc56a9a58979bce25eeded283

M       compose/ui/ui-text-google-fonts/api/current.txt
M       compose/ui/ui-text-google-fonts/api/public_plus_experimental_current.txt
M       compose/ui/ui-text-google-fonts/api/restricted_current.txt
M       compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt

https://android-review.googlesource.com/2329997

Project: platform/frameworks/support
Branch: androidx-main

commit 0490e25b6d1a7e57410d3c80f77720542d3a6150
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Dec 06 11:00:27 2022

    Promote DeviceFontFamilyName to stable API
   
    This is used to lookup fonts from on-device
   
    Test: n/a
    Bug: b/261435386
    Relnote: "DeviceFontFamilyName is now a stable API."
    Change-Id: I8b640d1d7880dcd7c581f53ff71baf2af0e80860

M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt

https://android-review.googlesource.com/2328890

Project: platform/frameworks/support
Branch: androidx-main

commit 16b130bf7dcfe07f1166c4c74816ddada1c90a4e
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Dec 06 10:53:10 2022

    Remove deprecated (experimental) font constructor
   
    Test: n/a
    Relnote: "Removed deprecated experimental font constructor."
    Bug: b/261435386
    Change-Id: I8a7245a0eb552b0df8c6bc9344451ccca0d2d2b1

M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt

https://android-review.googlesource.com/2328889

Project: platform/frameworks/support
Branch: androidx-main

commit 1f01456faf1bd74c9107139dfb4ad86e7cf9b9c0
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Dec 06 10:40:13 2022

    Promote createFontFamilyResolver to stable
   
    CoroutineContext API has shown high usage among developres debugging async font loading. Keeping the API as stable.
   
    Bug: b/261435386
    Test: n/a
    Relnote: "createFontFamilyResolver(context, coroutineContext) is now stable API. This can be used to catch uncaught exceptions during async font loading."
    Change-Id: Ibb481cae9c40a1e3ed26e7da911be24fab1788b6

M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/FontFamilyResolver.android.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.android.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontFamilyResolver.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontListFontFamilyTypefaceAdapter.kt
M       compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.skiko.kt

https://android-review.googlesource.com/2328886

Project: platform/frameworks/support
Branch: androidx-main

commit 86282a77fe4f637892c690640af6310584a670c4
Author: Sean McQuillan <seanmcq@google.com>
Date:   Tue Dec 06 10:21:58 2022

    Promote Font.loadingStrategy to stable
   
    Also stabilize (internal) max async timeout.
   
    Bug: b/261435386
    Test: n/a (is just annotation removal)
    Relnote: "Promote Font.loadingStrategy to stable API."
   
    Change-Id: I5937cfa2e03047eb3affd2c07fb4f75eb35faa97

M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt

https://android-review.googlesource.com/2328479