Experimental Focus APIs [261436820]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 5, 2022 04:01PM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
576510cc7d0d	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2021-01-07 14:13:29 -0800 499)	method @androidx.compose.ui.ExperimentalComposeUiApi public androidx.compose.ui.focus.FocusRequester.Companion.FocusRequesterFactory createRefs();
576510cc7d0d	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2021-01-07 14:13:29 -0800 506)	@androidx.compose.ui.ExperimentalComposeUiApi public static final class FocusRequester.Companion.FocusRequesterFactory {
e5cb882c220a	compose/foundation/foundation/api/public_plus_experimental_current.txt	(Ralston Da Silva	2022-02-11 14:11:09 -0800 73)	method @androidx.compose.foundation.ExperimentalFoundationApi public static androidx.compose.ui.Modifier focusGroup(androidx.compose.ui.Modifier);

Comments

ra...@google.com <ra...@google.com> #2Jan 4, 2023 08:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 228085e8d5f891a40d855254db35abd10d71d3e2
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 12 03:34:16 2020

Deleting deprecated focus code which was replaced by the new focus API

Bug: 160922116
Bug: 160821157
Bug: 162441435
Bug: 160822875
Bug: 160921940
Test: N/A removing unused code
Relnote: Removed deprecated FocusModifier
Change-Id: I0b4ba5c6f28b683787848042af76ac9ec20c7caf

M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/FocusModifier.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifierImpl.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusNodeUtils.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusState.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedFocusNode.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt

https://android-review.googlesource.com/1397868

ra...@google.com <ra...@google.com> #3Jan 5, 2023 11:57PM

couldn't submit aosp/2374998 before the API freeze deadline. Will submit this in the next release.

cl...@google.com <cl...@google.com> #4Jan 6, 2023 10:28AM

How crucial is to get this in? API freeze is our last alpha cut and we account for time to have API Council review the APIs before the real freeze, we can have this go in if you think it is important to land in M6, and just ensure we have a review in time

(adding Alex for visibility)

ra...@google.com <ra...@google.com> #5Jan 12, 2023 06:09PM

I don't think this is critical. It is just a helper API to easily create a bunch of FocusRequesters. I think we can make this stable in the next release.

ap...@google.com <ap...@google.com> #6Feb 15, 2024 08:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit d7e8651dcf76abebc90ab430587b14a2670455c0
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Jan 03 23:42:13 2023

Make FocusRequester.createRefs stable

Bug: 261436820
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.ui.focus.FocusRequesterTest
Relnote: FocusRequester.createRefs is now stable
Change-Id: I4d92c644c57436fcd4883bc73fe0120ffa0a6fb2

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/FocusableBoundsTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/FocusableTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/DefaultKeyboardActionsTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ConditionalFocusabilityDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/CustomFocusOrderDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusManagerMoveFocusDemo.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/FocusSamples.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusChangedTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusEventCountTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusRequesterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt

https://android-review.googlesource.com/2374998

ra...@google.com <ra...@google.com> May 14, 2024 08:55PM

Marked as fixed.

Issue 261436820