Experimental Nav Drawer APIs [261439597]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 5, 2022 04:19PM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	Author	Date & Line Number	API
d1aba6064d4c	(Matvei Malkov	2022-02-07 18:31:52 +0000 563)	@androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Stable public interface NavigationDrawerItemColors {
d1aba6064d4c	(Matvei Malkov	2022-02-07 18:31:52 +0000 570)	@androidx.compose.material3.ExperimentalMaterial3Api public final class NavigationDrawerItemDefaults {
d1aba6064d4c	(Matvei Malkov	2022-02-07 18:31:52 +0000 582)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void NavigationDrawerItem(
486fbb0c8b2d	(Connie Shi	2022-07-14 11:12:22 -0400 579)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void DismissibleNavigationDrawer(kotlin.jvm.functions.Function0<kotlin.Unit> drawerContent
486fbb0c8b2d	(Connie Shi	2022-07-14 11:12:22 -0400 581)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void ModalNavigationDrawer(kotlin.jvm.functions.Function0<kotlin.Unit> drawerContent
486fbb0c8b2d	(Connie Shi	2022-07-14 11:12:22 -0400 584)	method @androidx.compose.material3.ExperimentalMaterial3Api @androidx.compose.runtime.Composable public static void PermanentNavigationDrawer(kotlin.jvm.functions.Function0<kotlin.Unit> drawerContent

Comments

co...@google.com <co...@google.com> #2Dec 13, 2022 07:15PM

Reassigned to co...@google.com.

Relevant APIs: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt;l=318

co...@google.com <co...@google.com> Dec 14, 2022 07:26PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #3Dec 15, 2022 04:45PM

After some brief poking around:

Relevant code in LayoutNode: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt;l=421?q=semantics%20f:layoutnode&ss=androidx%2Fplatform%2Fframeworks%2Fsupport:compose%2F

Ends up here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt;l=2152?q=onSemanticsChange%20lang:kt&ss=androidx%2Fplatform%2Fframeworks%2Fsupport:compose%2F

If accessibility is off, looks like changing progress semantics a no op which would be a big improvement to performance.

Otherwise semantics does a remeasure / relayout, and walks the full semantics tree. This would likely have no immediate benefit if accessibility is turned on.

co...@google.com <co...@google.com> Dec 19, 2022 06:49PM

Marked as fixed.

na...@google.com <na...@google.com> #4Jan 11, 2023 08:11PM

Would this suggestion also avoid recomposing, which seems like it would still be a problem even if it's a no-op in the guts of semantic node code.

Issue 261439597