Experimental PointerInput APIs [261560988]

Assigned

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 6, 2022 11:25AM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
210960caf168	compose/ui/ui/api/public_plus_experimental_current.txt	(Adam Powell	2021-05-26 17:17:26 -0700 1872)	method @androidx.compose.ui.ExperimentalComposeUiApi public static androidx.compose.ui.Modifier pointerInteropFilter(androidx.compose.ui.Modifier
210960caf168	compose/ui/ui/api/public_plus_experimental_current.txt	(Adam Powell	2021-05-26 17:17:26 -0700 1899)	@androidx.compose.ui.ExperimentalComposeUiApi public final class RequestDisallowInterceptTouchEvent implements kotlin.jvm.functions.Function1<java.lang.Boolean, kotlin.Unit> {
5a3239c66b33	compose/ui/ui/api/public_plus_experimental_current.txt	(George Mount	2021-11-03 13:55:22 -0700 1840)	method @androidx.compose.ui.ExperimentalComposeUiApi public boolean getShareWithSiblings();

Comments

jo...@google.com <jo...@google.com> #2Jan 16, 2023 10:51AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

mo...@google.com <mo...@google.com> #3Jan 17, 2023 05:15PM

Reassigned to je...@google.com.

I have been assigned to progressive back, so any Compose work that depends on me has been pushed back.

I'm not sure we should support pointerInteropFilter as a public API. We have another API that could be a better candidate for public consumption, motionEventSpy. This needs some discussion.

RequestDisallowInterceptTouchEvent would disappear if we don't support pointerInteropFilter.

I think that getShareWithSiblings can be made public at this point.

Reassigning to jewalker@

je...@google.com <je...@google.com> #4Jan 27, 2023 12:50AM

@Jolanda, I created two lists after talking with George (details below). Some of them we hope to deprecate instead.

If the ones you are asking about are in the deprecation list, please let me know the use case. Thanks!

Mark as non-experimental:

getShareWithSiblings
motionEvenSpy - related one for getting MotionEvent if needed

Deprecate:

pointerInteropFilter - We want devs using 'pointerInput' or, if they need to see a MotionEvent, motionEvenSpy
RequestDisallowInterceptTouchEvent - Related to the one above, so it would go with it.

jo...@google.com <jo...@google.com> #5Jan 31, 2023 01:37PM

This looks good! I haven't used these functions, but was looking into input and just wondered about the status.

ap...@google.com <ap...@google.com> #6Mar 29, 2023 09:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit b49dbe441ba3487bd1cbbc045d2107474589ecd4
Author: Jeremy Walker <jewalker@google.com>
Date: Fri Mar 17 14:02:35 2023

Removes experiemental from PointerInputChange.

Bug: 261560988, 261565762, 261565749
Test: Ran existing tests.
Relnote: Changes experimental APIs to stable in PointerInputChange.
Change-Id: I1b5430f6bece9ee985a2a45b820dd5e5334832ec

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.kt

https://android-review.googlesource.com/2496340

ap...@google.com <ap...@google.com> #7Mar 30, 2023 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit d922bf1dc2e5a0a2004291a8e96e6075737ab9b9
Author: Jeremy Walker <jewalker@google.com>
Date: Wed Mar 29 14:58:19 2023

Moves motionEventSpy to stable.

Test: Uses existing tests:
Bug: 261560988
Relnote: Changes motionEventSpy to stable.
Change-Id: Ic5ec4ef446908ae7fca45c5d3c6c816b61a8029f

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/PointerInteropFilter.android.kt

https://android-review.googlesource.com/2514599

je...@google.com <je...@google.com> #8Mar 30, 2023 05:23PM

All items that were marked to be stable are now in the latest alpha.

I'm still working through deprecating the other ones, but that should cover the main focus of this bug.