Experimental PointerInput APIs [261560988]

Assigned

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 6, 2022 11:25AM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
210960caf168	compose/ui/ui/api/public_plus_experimental_current.txt	(Adam Powell	2021-05-26 17:17:26 -0700 1872)	method @androidx.compose.ui.ExperimentalComposeUiApi public static androidx.compose.ui.Modifier pointerInteropFilter(androidx.compose.ui.Modifier
210960caf168	compose/ui/ui/api/public_plus_experimental_current.txt	(Adam Powell	2021-05-26 17:17:26 -0700 1899)	@androidx.compose.ui.ExperimentalComposeUiApi public final class RequestDisallowInterceptTouchEvent implements kotlin.jvm.functions.Function1<java.lang.Boolean, kotlin.Unit> {
5a3239c66b33	compose/ui/ui/api/public_plus_experimental_current.txt	(George Mount	2021-11-03 13:55:22 -0700 1840)	method @androidx.compose.ui.ExperimentalComposeUiApi public boolean getShareWithSiblings();

Comments

jo...@google.com <jo...@google.com> #2Jan 16, 2023 10:51AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mo...@google.com <mo...@google.com> #3Jan 17, 2023 05:15PM

Reassigned to je...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

je...@google.com <je...@google.com> #4Jan 27, 2023 12:50AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

jo...@google.com <jo...@google.com> #5Jan 31, 2023 01:37PM

This looks good! I haven't used these functions, but was looking into input and just wondered about the status.

ap...@google.com <ap...@google.com> #6Mar 29, 2023 09:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit b49dbe441ba3487bd1cbbc045d2107474589ecd4
Author: Jeremy Walker <jewalker@google.com>
Date: Fri Mar 17 14:02:35 2023

Removes experiemental from PointerInputChange.

Bug: 261560988, 261565762, 261565749
Test: Ran existing tests.
Relnote: Changes experimental APIs to stable in PointerInputChange.
Change-Id: I1b5430f6bece9ee985a2a45b820dd5e5334832ec

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.kt

https://android-review.googlesource.com/2496340

ap...@google.com <ap...@google.com> #7Mar 30, 2023 05:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit d922bf1dc2e5a0a2004291a8e96e6075737ab9b9
Author: Jeremy Walker <jewalker@google.com>
Date: Wed Mar 29 14:58:19 2023

Moves motionEventSpy to stable.

Test: Uses existing tests:
Bug: 261560988
Relnote: Changes motionEventSpy to stable.
Change-Id: Ic5ec4ef446908ae7fca45c5d3c6c816b61a8029f

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/PointerInteropFilter.android.kt

https://android-review.googlesource.com/2514599

je...@google.com <je...@google.com> #8Mar 30, 2023 05:23PM

All items that were marked to be stable are now in the latest alpha.

I'm still working through deprecating the other ones, but that should cover the main focus of this bug.