Experimental Focus Direction APIs [261564106]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 6, 2022 12:37PM

The following Experimental APIs have existed for several releases.

Please consider stabilising or removing these APIs:

SHA	File (if available)	Author	Date & Line Number	API
8bbfa2fd7f3c	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2022-08-29 16:16:07 -0700 454)	method @androidx.compose.ui.ExperimentalComposeUiApi public default kotlin.jvm.functions.Function1<androidx.compose.ui.focus.FocusDirection
8bbfa2fd7f3c	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2022-08-29 16:16:07 -0700 455)	method @androidx.compose.ui.ExperimentalComposeUiApi public default kotlin.jvm.functions.Function1<androidx.compose.ui.focus.FocusDirection
8bbfa2fd7f3c	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2022-08-29 16:16:07 -0700 465)	method @androidx.compose.ui.ExperimentalComposeUiApi public default void setEnter(kotlin.jvm.functions.Function1<? super androidx.compose.ui.focus.FocusDirection
8bbfa2fd7f3c	compose/ui/ui/api/public_plus_experimental_current.txt	(Ralston Da Silva	2022-08-29 16:16:07 -0700 466)	method @androidx.compose.ui.ExperimentalComposeUiApi public default void setExit(kotlin.jvm.functions.Function1<? super androidx.compose.ui.focus.FocusDirection

Comments

ra...@google.com <ra...@google.com> #2Jan 4, 2023 06:31PM

Keeping this experimental until we find an elegant solution for b/235681940

ap...@google.com <ap...@google.com> #3Apr 10, 2024 08:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit e09bbff3e84316c39e594b1219d9cefb6d579e2a
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Apr 09 14:00:12 2024

Stabilize focus APIs

Stabilize the following APIs:
FocusProperties.enter
FocusProperties.exit
FocusDirection.Enter
FocusDirection.Exit
FocusRequester.Cancel

Bug: 261564106
Test: Updated all affected tests
Relnote: "FocusProperties.enter and FocusProperties.exit
are no longer experimental. FocusDirection.Enter and
FocusDirection.Exit are no longer experimental.
FocusRequester.Cancel is no longer experimental"

Change-Id: I461a1335e08f7ec1b944e145d18d5559377a95c8

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/LazyListChildFocusDemos.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/FocusSamples.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/CancelFocusMoveTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/ClearFocusExitTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusTransactionsTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalExitTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitExitTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/viewinterop/FocusGroupNode.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusDirection.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwnerImpl.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusProperties.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifierNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRestorer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M tv/integration-tests/playground/src/main/java/androidx/tv/integration/playground/FeaturedCarousel.kt
M tv/integration-tests/presentation/src/main/java/androidx/tv/integration/presentation/createCustomInitialFocusRestorerModifiers.kt
M tv/tv-material/src/androidTest/java/androidx/tv/material3/CarouselTest.kt

https://android-review.googlesource.com/3034657

ra...@google.com <ra...@google.com> Apr 11, 2024 08:46PM

Marked as fixed.

na...@google.com <na...@google.com> #4Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.7.0-alpha07
androidx.compose.ui:ui-android:1.7.0-alpha07
androidx.compose.ui:ui-desktop:1.7.0-alpha07

ap...@google.com <ap...@google.com> #5May 23, 2024 07:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit c21050d32d60cdee5af48564f3ddaa83b608909e
Author: Ralston Da Silva <ralu@google.com>
Date: Wed May 22 22:16:19 2024

Revert "Stabilize focus APIs"

This reverts commit e09bbff3e84316c39e594b1219d9cefb6d579e2a.

Reason for revert: We found some issues with the focus transaction design and want to keep this experimental for 1.7
Relnote: "Reverted the change that marked FocusProperties.enter, FocusProperties.exit, FocusDirection.Enter, FocusDirection.Exit and FocusRequester.Cancel as non-experimental."
Bug: 261564106
Test: N/A
Change-Id: I0428cce7a823d56cb55ec2b9a6b5d426f68dd526

M compose/ui/ui/api/1.7.0-beta02.txt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_1.7.0-beta02.txt
M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/LazyListChildFocusDemos.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/FocusSamples.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/CancelFocusMoveTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/ClearFocusExitTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusTransactionsTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalExitTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitEnterTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitExitTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/viewinterop/FocusGroupNode.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusDirection.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwnerImpl.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusProperties.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifierNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRestorer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt
M tv/tv-material/src/androidTest/java/androidx/tv/material3/CarouselTest.kt

https://android-review.googlesource.com/3097743

na...@google.com <na...@google.com> #6May 29, 2024 06:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.7.0-beta02
androidx.compose.ui:ui-android:1.7.0-beta02
androidx.compose.ui:ui-desktop:1.7.0-beta02

na...@google.com <na...@google.com> #7Jul 10, 2024 05:10PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-rc01

Issue 261564106

Description

Issue summary

Comments

ra...@google.com <ra...@google.com> #2Jan 4, 2023 06:31PM

ap...@google.com <ap...@google.com> #3Apr 10, 2024 08:34PM

ra...@google.com <ra...@google.com> Apr 11, 2024 08:46PM

na...@google.com <na...@google.com> #4Apr 17, 2024 05:17PM

ap...@google.com <ap...@google.com> #5May 23, 2024 07:08PM

na...@google.com <na...@google.com> #6May 29, 2024 06:05PM

na...@google.com <na...@google.com> #7Jul 10, 2024 05:10PM

Add comment

Issue metadata