Status Update
Comments
gb...@manubank.com <gb...@manubank.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
pr...@gmail.com <pr...@gmail.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
an...@google.com <an...@google.com> #4
we...@sky.uk <we...@sky.uk> #5
Like us, I think this will be the last issue preventing people from fully migrating from M2 -> M3. Until this is resolved we can't fully remove the material dependency from our build files as per the migration guidelines.
al...@google.com <al...@google.com>
se...@google.com <se...@google.com>
se...@google.com <se...@google.com> #6
The latest update here:
There are some critical design concerns with pullrefresh in M2 that we would like to address before we ultimately decide to provide an M3 implementation of this component. Once this M2 work is prioritized we will be able to provide a more concrete timeline on an M3 implementation.
se...@google.com <se...@google.com>
co...@google.com <co...@google.com>
se...@google.com <se...@google.com>
re...@gmail.com <re...@gmail.com> #7
And for now, how can we use the pull to refresh features?
se...@google.com <se...@google.com> #8
PullRefresh is a known migration gap from M2 and is in active development. I dont have a strong estimate for its timeline yet but this bug will be updated as different components of this behavior are implemented.
The best way to use PullRefresh with M3 currently is to fork the M2 logic in the meantime.
st...@gmail.com <st...@gmail.com> #9
4s...@gmail.com <4s...@gmail.com> #10
je...@gmail.com <je...@gmail.com> #11
What a strange decision ! Almost every app uses pull to refresh. If you think you can improve the component, then do it, but implement the standard pull to refresh first.
ja...@gmail.com <ja...@gmail.com> #12
ja...@gmail.com <ja...@gmail.com> #13
This is a blocking issue for upgrading to M3 for us as well.
ap...@google.com <ap...@google.com> #14
Branch: androidx-main
commit 13a9759288d8af0548e08d428cb431ae30b14e51
Author: José Figueroa Santos <serniebanders@google.com>
Date: Wed Aug 16 19:42:27 2023
[Material3][PullRefresh] Add pullRefresh screenshot assets
Bug: 261760718
Change-Id: Ia0f6a6cf85e9acf5195b1b0a9e029d342e8bc5f0
A compose/material3/material3/pullRefreshIndicator_darkTheme_progress_emulator.png
A compose/material3/material3/pullRefreshIndicator_darkTheme_refreshing_emulator.png
A compose/material3/material3/pullRefreshIndicator_darkTheme_scale_emulator.png
A compose/material3/material3/pullRefreshIndicator_lightTheme_progress_emulator.png
A compose/material3/material3/pullRefreshIndicator_lightTheme_refreshing_emulator.png
A compose/material3/material3/pullRefreshIndicator_lightTheme_scale_emulator.png
ap...@google.com <ap...@google.com> #15
Branch: androidx-main
commit b82bdf308cc6144b693839eef9938e10b050e1ea
Author: Jose Figueroa <serniebanders@google.com>
Date: Wed Jul 19 17:33:30 2023
[Material3][PullRefresh] Fork M2 Implementation of PullRefreshIndicator
Test: N/A
Bug: 261760718
Change-Id: I8319a37d15fb7e10dbcfa399012bd528d8263d7e
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicatorTest.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicator.kt
ap...@google.com <ap...@google.com> #16
Branch: androidx-main
commit 63b87bff724635e0086c37ae0977a5de537fc4cc
Author: Jose Figueroa <serniebanders@google.com>
Date: Wed Jul 19 18:14:02 2023
[Material3][PullRefresh] Update PullRefreshIndicator to M3
* API has been updated to be agnostic to PullRefreshState
* TonalElevation behavior has not been ported to M3
* PullRefreshIndicatorTransformation logic has been moved here
* Note: PullRefreshIndicator and PullRefreshIndicatorDefaults will be marked as public alongside the introduction of PullRefresh behavior.
Bug: 261760718
Test: Unit Tests and Screenshot tests for custom non-surface behaviors (progress, offset and refreshing).
Change-Id: I79f7a9d5bf9c08cd50b6f14133417f9c14af8bc3
D compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicatorTest.kt
A compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicatorScreenshotTest.kt
A compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicatorTest.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pullrefresh/PullRefresh.kt
D compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pullrefresh/PullRefreshIndicator.kt
ja...@gmail.com <ja...@gmail.com> #17
It's merged or? When will this be available?
vo...@gmail.com <vo...@gmail.com> #18
Hello Guys, how far are we on the PullRefreshIndicator
? I am a bit hesitant to add an entire MD2 Lib in the name of an indicator.
ma...@gmail.com <ma...@gmail.com> #19
Please expose the shadow colors in the M3 version of the indicator. I did not find a way to override the shadow colors since the modifier is applied after any modifiers supplied.
.shadow(if (showElevation) Elevation else 0.dp, SpinnerShape, clip = true)
->
.shadow(if (showElevation) Elevation else 0.dp, SpinnerShape, clip = true, ambientColor = ambientColor, spotColor = spotColor)
ap...@google.com <ap...@google.com> #20
Branch: androidx-main
commit d6595618337308b4a133162833c92fb6ebf4a2fb
Author: Jose Figueroa <serniebanders@google.com>
Date: Wed Sep 27 13:54:40 2023
[Material3][PullToRefresh] Implement custom state behavior for Pull-to-Refresh
Bug: 261760718
RelNote: "Implements PullToRefreshContainer and PullToRefreshState, which together provide a pull to refresh implementation in Material3."
Test: Unit and Screenshot tests provided for PullToRefreshContainer and PullToRefreshState
Change-Id: I1645695db83e706b2f20e25b82bb937885d95abf
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Components.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
A compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/PullToRefreshSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshIndicatorScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshIndicatorTest.kt
A compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshStateImplTest.kt
D compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pullrefresh/PullRefresh.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pulltorefresh/PullToRefresh.kt
se...@google.com <se...@google.com> #21
This has been landed as an Experimental component. The plan is to have this extensively tested and reviewed for API and behavior, as well as future design plans within Material 3. Please open separate bugs and feature requests as this component becomes available in future releases. And thank you for the continued patience on this one.
Description