NPE / assertion error in CF frame verifier [261967650]

Fixed

Bug

Status Update

No update yet.

Description

ze...@google.com

created issue #1

Dec 9, 2022 12:13PM

This issue was found as part of investigating b/261757444 which coincidentally used some missing types from javax.

Comments

ap...@google.com <ap...@google.com> #2Dec 9, 2022 12:43PM

Gradle issue asking for it to be made easier to avoid making an unused modification to this list: https://github.com/gradle/gradle/issues/22671

ze...@google.com <ze...@google.com> #3Dec 9, 2022 01:36PM

I think the issue here is that jvmArgs is null, which causes addAll() to not run.

IMO we should be adding to jvmArgs and not replacing it entirely, in case something else has previously set jvmArgs. WYT @Ivan?

I could change it to something like

forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs) ?: forkOptions.jvmArgs(executionOptions.get().jvmArgs)

ap...@google.com <ap...@google.com> #4Dec 12, 2022 07:25AM

Yeah, the nullness of jvmArgs was the first possibility I checked too, although even with "!!" it still had no effect, see https://github.com/gradle/gradle/issues/22671

I uploaded a change that I observed to fix it for me and added you as a reviewer

ap...@google.com <ap...@google.com> #5Dec 12, 2022 07:25AM

Ah, ok, that makes sense.

ap...@google.com <ap...@google.com> #6Dec 12, 2022 07:25AM

Thanks for the change, Jeff!

Should we cherry-pick it into 7.4? I think AGP 7.4 has that but the settings plugin is not officially supported yet.

ap...@google.com <ap...@google.com> #7Dec 12, 2022 07:25AM

Cherry-pick to AGP 7.4 branch is here. It's not merged yet, and I don't have an opinion about whether it should be.

Can we add a regression test in studio-main for this?

ap...@google.com <ap...@google.com> #8Dec 12, 2022 07:26AM

Chờ nhận sp

ze...@google.com <ze...@google.com> Dec 20, 2022 08:09AM

Marked as fixed.

sa...@google.com <sa...@google.com> #9Dec 27, 2022 06:45PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Electric Eel RC 3 (2022.1.1.18)
Android Gradle Plugin 7.4.0-rc03

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!