Status Update
No update yet.
Comments
ph...@gmail.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ph...@gmail.com
se...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ca...@gmail.com
ra...@google.com
Hi Marcelo, can you please take a look at this when you get a chance ? If not, I can come and take a look when I get back.
ma...@google.com
I'm pretty sure the offending PR here is aosp/2333568 - that is the only PR touching the profile transcoding.
It fixes an important bug with compressed profiles but it seems that the new code is slower than before.
cc...@google.com
If you look in the dashboard, the commit link is wrong, since it doesn't encompass all builds since the previous (9385400). Correct build range link is here, which includes Ben's CL:
(If a build goes missing for any reason, it corrupts the commit link. In general, you can always go to dashboard, and create range link like the above)
be...@google.com
Yes, it looks like my change introduced this regression.
If I read
That would mean the change makes opening the file slower by about 1000 times.
Chris: Given this runs on a background thread and is not blocking app startup, is it urgent to address this or can it wait for the next release cycle?
be...@google.com
Uploaded aosp/2355662 to address the problem.
be...@google.com
The CL mentioned in
mo...@google.com
ap...@google.com
Branch: androidx-main
commit b7fc1b0247a4f4883b37c1998e3f12b4f0c0b7b0
Author: Ben Weiss <benweiss@google.com>
Date: Wed Dec 14 15:49:17 2022
More detailed compressed profile handling
Just replacing openFd with open dramatically decreased the performance
of opening a profile. This new handling goes back to openFd and
introduces a diagnostic code to hint at updating bundletool.
Bug: 261998144
Test: :profileinstaller:profileinstaller:test
RelNote: Add diagnostics for compressed profiles
Change-Id: I8641387ad6073dde588d0d764da4a3b24b1c8ee4
M profileinstaller/profileinstaller/api/current.txt
M profileinstaller/profileinstaller/api/public_plus_experimental_current.txt
M profileinstaller/profileinstaller/api/restricted_current.txt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/DeviceProfileWriter.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileInstaller.java
be...@google.com
The landed CL has moved the benchmark down to normal levels again.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.profileinstaller:profileinstaller:1.3.0-beta01
Description
Alert on dashboard:https://androidx-perf.skia.org/t/?begin=1670529681&end=1670529682&subset=all
CLs in build:https://android-build.googleplex.com/builds/branch-dashboard/aosp-androidx-main?build_id=9385668
The commit points to a CL that has no real change (just reformatting), so something else is going on.
Sean, can you look and see why this benchmark is going crazy?