ProfileInstallerTranscodeBenchmark increased for unknown reason [261998144]

Verified

Bug

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Dec 9, 2022 05:50PM

Alert on dashboard: https://androidx-perf.skia.org/t/?begin=1670529681&end=1670529682&subset=all

CLs in build: https://android-build.googleplex.com/builds/branch-dashboard/aosp-androidx-main?build_id=9385668

The commit points to a CL that has no real change (just reformatting), so something else is going on.

Sean, can you look and see why this benchmark is going crazy?

Comments

ph...@gmail.com <ph...@gmail.com> #2Dec 9, 2022 06:32PM

jsjeon@ do you know why that might be?

ph...@gmail.com <ph...@gmail.com> #3Dec 9, 2022 06:34PM

Any concrete examples I can take a look at?

One possibility is, as explained at https://kotlinlang.org/docs/annotations.html#annotation-use-site-targets, property use-site target has a higher priority over field, and

but the property itself in Metalava's output is not.

here Metalava's output should be Java field and accessor methods, so I guess @Deprecated could be not properly propagated to field.

se...@google.com <se...@google.com> #4Dec 9, 2022 07:30PM

Reassigned to ra...@google.com.

https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2369848/12/wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/ScalingLazyListItemInfo.kt

and

https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2369848/12/wear/compose/compose-material/api/current.txt#427

ca...@gmail.com <ca...@gmail.com> #5Dec 10, 2022 02:16PM

Project: platform/tools/metalava
Branch: metalava-main

commit ac6b7a3779511b5be53c4f8dfbdfcdf1508764e6
Author: Jinseong Jeon <jsjeon@google.com>
Date: Thu Mar 02 23:37:39 2023

Propagate deprecation of containing class to property

...in the same way method/field are deprecated

Bug: 271441831
Test: unit test added
Change-Id: I899b80a484866a44be9aa244d00552ebce148335

M src/main/java/com/android/tools/metalava/ApiAnalyzer.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt

https://android-review.googlesource.com/2468803

ra...@google.com <ra...@google.com> #6Dec 10, 2022 04:25PM

Reassigned to ma...@google.com.

Project: platform/prebuilts/androidx/external
Branch: androidx-main

commit b712ab052930d4900a7f060d67bbd3cee2933970
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 22:51:50 2023

Update Metalava for build ID 9692962

./development/importMaven/importMaven.sh \
--metalava-build-id 9692962 \
--redownload com.android.tools.metalava:metalava:1.0.0-alpha07

Bug: 271441831
Bug: 271662790
Change-Id: Ide5946ed2a6b4248ffe5e822c760ed0b05034afd

M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.sha1

https://android-review.googlesource.com/2471011

ma...@google.com <ma...@google.com> #7Dec 12, 2022 08:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5d6108703fa3db420dde7b7ee805ca4172ed44fa
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 23:03:10 2023

Update current API signature after Metalava update

Relnote: propagation of @Deprecated class to property
Bug: 271441831
Test: ./gradlew updateApi
Change-Id: I882d15d1d0d17f2227262e682d05d9dc7d082e8a

M annotation/annotation-experimental/api/current.txt
M annotation/annotation-experimental/api/public_plus_experimental_current.txt
M annotation/annotation-experimental/api/restricted_current.txt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-runtime/api/current.txt
M paging/paging-runtime/api/public_plus_experimental_current.txt
M paging/paging-runtime/api/restricted_current.txt
M wear/compose/compose-material/api/current.txt
M wear/compose/compose-material/api/public_plus_experimental_current.txt
M wear/compose/compose-material/api/restricted_current.txt
M wear/watchface/watchface-client/api/current.txt
M wear/watchface/watchface-client/api/public_plus_experimental_current.txt
M wear/watchface/watchface-client/api/restricted_current.txt
M wear/watchface/watchface/api/current.txt
M wear/watchface/watchface/api/public_plus_experimental_current.txt
M wear/watchface/watchface/api/restricted_current.txt

https://android-review.googlesource.com/2469886

Message last modified on Dec 12, 2022 08:27PM

cc...@google.com <cc...@google.com> #8Dec 12, 2022 09:10PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material:1.2.0-alpha07

Message last modified on Dec 12, 2022 09:11PM

be...@google.com <be...@google.com> #9Dec 13, 2022 02:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.watchface:watchface:1.2.0-alpha08
androidx.wear.watchface:watchface-client:1.2.0-alpha08

cc...@google.com <cc...@google.com> #10Dec 13, 2022 06:10PM

The number in the triage page is synthetic, you need to click through to the dashboard here to see the real nanos. It went from 0.2ms to 46ms, which is a huge slowdown. We should fix this before cherry-picking / releasing this change.

be...@google.com <be...@google.com> #11Dec 14, 2022 04:20PM

Accepted by be...@google.com.

Uploaded aosp/2355662 to address the problem.

be...@google.com <be...@google.com> #12Jan 18, 2023 06:09PM

Status: Assigned (reopened)

The CL mentioned in comment#11 will land shortly and should fix this issue.

mo...@google.com <mo...@google.com> Jan 18, 2023 06:51PM

Reassigned to be...@google.com.

ap...@google.com <ap...@google.com> #13Jan 20, 2023 06:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit b7fc1b0247a4f4883b37c1998e3f12b4f0c0b7b0
Author: Ben Weiss <benweiss@google.com>
Date: Wed Dec 14 15:49:17 2022

More detailed compressed profile handling

Just replacing openFd with open dramatically decreased the performance
of opening a profile. This new handling goes back to openFd and
introduces a diagnostic code to hint at updating bundletool.

Bug: 261998144
Test: :profileinstaller:profileinstaller:test
RelNote: Add diagnostics for compressed profiles

Change-Id: I8641387ad6073dde588d0d764da4a3b24b1c8ee4

M profileinstaller/profileinstaller/api/current.txt
M profileinstaller/profileinstaller/api/public_plus_experimental_current.txt
M profileinstaller/profileinstaller/api/restricted_current.txt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/DeviceProfileWriter.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileInstaller.java

https://android-review.googlesource.com/2355662

be...@google.com <be...@google.com> #14Jan 23, 2023 12:34PM

The landed CL has moved the benchmark down to normal levels again.

be...@google.com <be...@google.com> #15Jan 23, 2023 12:35PM

Verified by be...@google.com.

See dashboard

pr...@google.com <pr...@google.com> #16Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.profileinstaller:profileinstaller:1.3.0-beta01

Issue 261998144

Description

Issue summary

Comments

ph...@gmail.com <ph...@gmail.com> #2Dec 9, 2022 06:32PM

ph...@gmail.com <ph...@gmail.com> #3Dec 9, 2022 06:34PM

se...@google.com <se...@google.com> #4Dec 9, 2022 07:30PM

ca...@gmail.com <ca...@gmail.com> #5Dec 10, 2022 02:16PM

ra...@google.com <ra...@google.com> #6Dec 10, 2022 04:25PM

ma...@google.com <ma...@google.com> #7Dec 12, 2022 08:26PM

cc...@google.com <cc...@google.com> #8Dec 12, 2022 09:10PM

be...@google.com <be...@google.com> #9Dec 13, 2022 02:56PM

cc...@google.com <cc...@google.com> #10Dec 13, 2022 06:10PM

be...@google.com <be...@google.com> #11Dec 14, 2022 04:20PM

be...@google.com <be...@google.com> #12Jan 18, 2023 06:09PM

mo...@google.com <mo...@google.com> Jan 18, 2023 06:51PM

ap...@google.com <ap...@google.com> #13Jan 20, 2023 06:22PM

be...@google.com <be...@google.com> #14Jan 23, 2023 12:34PM

be...@google.com <be...@google.com> #15Jan 23, 2023 12:35PM

pr...@google.com <pr...@google.com> #16Feb 8, 2023 06:21PM

Add comment

Issue metadata