Regression: Keyboard not shown when in DialogFragment or ComponentDialog [262140644]

Fixed

Bug

Status Update

No update yet.

Description

al...@hu.ma

created issue #1

Dec 12, 2022 10:05AM

Jetpack Compose version: 1.4.0-alpha03

Jetpack Compose component(s) used: Foundation + Material

Android Studio Build: Any

Kotlin version: 1.7.21

Steps to Reproduce or Code Sample to Reproduce:

Add ComposeView into a BottomSheetDialogFragment or ComponentDialog
Add a TextField
Open sheet/dialog
Click on TextField
Keyboard doesn't show up

Sample, requires com.google.android.material:material:

class ContainerSheet : BottomSheetDialogFragment() {
  final override fun onCreateView(
    inflater: LayoutInflater,
    container: ViewGroup?,
    savedInstanceState: Bundle?,
  ): View = ComposeView(inflater.context).apply {
    layoutParams = ViewGroup.LayoutParams(
      ViewGroup.LayoutParams.MATCH_PARENT,
      ViewGroup.LayoutParams.MATCH_PARENT,
    )
    setContent {
      Column(
        modifier = Modifier.padding(
          start = 24.dp,
          end = 24.dp,
          bottom = 100.dp,
          top = 24.dp,
        ),
      ) {
        // doesn't work
        var text by remember { mutableStateOf("type here") }
        BasicTextField(value = text, onValueChange = { text = it })

        // works fine
        AndroidView(modifier = Modifier.fillMaxWidth(), factory = ::EditText) { it.hint = "android.widget.EditText"}
      }
    }
  }
}

class RootActivity: AppCompatActivity() {
  override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    setContent {
      AppTheme {
        Box(
          modifier = Modifier
            .fillMaxSize()
            .padding(100.dp),
        ) {
          Button(
            onClick = {
              sheet.show(supportFragmentManager, "sheet")
            },
            content = {
              Text("Show sheet")
            }
          )
        }
      }
    }
  }
}

Worked fine on 1.4.0-alpha02

Comments

nj...@google.com <nj...@google.com> Dec 12, 2022 06:48PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Dec 12, 2022 07:09PM

Reassigned to ra...@google.com.

va...@google.com <va...@google.com> #2Dec 15, 2022 05:50PM

I believe I'm having a related problem on certain devices. I set the systemBarBehavior as seen in line below:

WindowInsetsControllerCompat(window, main_container).systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE

Although I'm setting the system bar behavior to BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE, it seems to be behaving as BEHAVIOR_SHOW_BARS_BY_TOUCH on some devices. After i hide the system UI (see fun below) then touch the screen the bottom system navigation bar appears (the status bar remains hidden). When i swipe down from the top, the system status bar does appear transparent and goes away after a few seconds but the bottom system nav bar remains and isn't transparent.

Bug appears on: Galaxy s9+ (android 10), Galaxy Note 10+ (android 10). Bug does not appear on: Google Pixel 3a (android 11), Google Pixel 3 (android 11). I haven't tested on any other devices besides Galaxy s6 but that phone has hardware buttons so it doesn't apply.

Here's my code to go into full screen mode:

// Hide the app action bar, system status bar and system navigation bar
private fun hideSystemUI() {
    supportActionBar?.hide()
    WindowCompat.setDecorFitsSystemWindows(window, false)
    WindowInsetsControllerCompat(window, main_container).let { controller ->
        controller.hide(WindowInsetsCompat.Type.statusBars() or WindowInsetsCompat.Type.navigationBars())
        controller.systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
    }
}

va...@google.com <va...@google.com> #3Dec 15, 2022 06:01PM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Nokia 7.2 as well

al...@hu.ma <al...@hu.ma> #4Dec 15, 2022 06:23PM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Xiaomi Redmi Note 9S using Android 10 (MIUI 12) as well.

yu...@gmail.com <yu...@gmail.com> #5Jan 13, 2023 02:17AM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Moto one power (Android 10) as well

ComposeDialogFragment.zip

1.4 MB

Download

te...@gmail.com <te...@gmail.com> #6Jan 31, 2023 07:09PM

This is more of a missing feature as nobody has implemented the setSystemBarsBehavior in Impl20 which is the implementation used on pre-30 devices. This shouldn't be such a big deal to implement but it is crucial for correct compat behavior. Please fix this asap!

cj...@gmail.com <cj...@gmail.com> #7Feb 10, 2023 07:05AM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Realme X2 Pro Android 10 as well. (Core ktx Version 1.5.0-beta01)

va...@google.com <va...@google.com> #8Feb 10, 2023 10:27PM

Bug is real on every android 10 device wich i have on all alphas and beta core ctx versions.

go...@gmail.com <go...@gmail.com> #9Mar 30, 2023 01:01PM

I assumed the old method is implemented since Core is on beta release already, but upon closer inspection the method only implemented for API 30. Revert revert we go...

ae...@google.com <ae...@google.com> Apr 4, 2023 08:21PM

Reassigned to kl...@google.com.

ca...@sitoo.com <ca...@sitoo.com> #10Apr 12, 2023 07:03AM

Hi, is there someone already working on this? I needed this feature so I implemented it. I can improve it and submit a pull request :D

ra...@gmail.com <ra...@gmail.com> #11Apr 12, 2023 07:24AM

Thank you all for reporting this bug. We are actively working on this but the backport implementation uncovered some other bugs that need to be fixed and tested in order to submit all the changes. https://android-review.googlesource.com/c/platform/frameworks/support/+/1598475

ca...@sitoo.com <ca...@sitoo.com> #12Apr 12, 2023 07:45AM

This is blocking for the correct usage of WindowInsetsControllerCompat.

Is someone still working on this?

en...@gmail.com <en...@gmail.com> #13Apr 12, 2023 09:22AM

+1 on this issue

kl...@google.com <kl...@google.com> Apr 13, 2023 09:36PM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #14Apr 14, 2023 02:05AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 480d10395d28bf22e9f4539f4b992a344628779b
Author: Vadim Caen <caen@google.com>
Date: Mon Feb 08 16:23:39 2021

Implement setSystemBarsBehavior for pre 30 SDK

Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_swipe
Test:
WindowInsetsControllerCompatActivityTest#systemBarsBehavior_transient
Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_touch
Bug: 173203649

Change-Id: I062c841f0e4201fddfcf1489dbfaff605bebbdb6

M core/core/src/androidTest/java/androidx/core/view/WindowInsetsAnimationCompatActivityTest.kt
M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsAnimationCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java
M samples/Support4Demos/src/main/java/com/example/android/supportv4/view/WindowInsetsControllerPlayground.kt
M samples/Support4Demos/src/main/res/layout/activity_insets_controller.xml

https://android-review.googlesource.com/1612119

ch...@gmail.com <ch...@gmail.com> #15Apr 17, 2023 07:43AM

@14 I forgot why I even starred this...
Is this a deprecation issue, or something to implement for new/old API of Android?

st...@google.com <st...@google.com> #16Apr 17, 2023 03:28PM

Android R introduced WindowInsetsController.setSystemBarsBehavior() and the API was added to Androidx but the backport was not implemented. It should be release in core:1.5.0 stable

ch...@gmail.com <ch...@gmail.com> #17Apr 18, 2023 02:36AM

getSystemBarsBehavior() is still unimplemented…

Message last modified on Apr 18, 2023 02:36AM

pr...@google.com <pr...@google.com> #18Apr 19, 2023 06:13PM

kotlin-> BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE is still acting like BEHAVIOR_SHOW_BARS_BY_TOUCH in core-ktx:1.6.0-alpha02 (assuming I have the right library) on api 28 and others in the emulator. Have to include window.decorView.systemUiVisibility = View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY to get previous behavior.

ap...@google.com <ap...@google.com> #19Apr 20, 2023 03:00PM

@#18 support for setSystemBarsBehavior on SDK < 30 has been added in core-ktx:1.6.0-alpha03, see here: https://developer.android.com/jetpack/androidx/releases/core#1.6.0-alpha03 I've updated my answer on stackoverflow to reflect: https://stackoverflow.com/a/64828028/3422470

ed...@gmail.com <ed...@gmail.com> #20Apr 23, 2023 01:36PM

Can anyone please demonstrate the use of it, and a screenshot with it vs without it?

Message last modified on Apr 23, 2023 01:46PM

an...@favordelivery.com <an...@favordelivery.com> #21Apr 27, 2023 04:57AM

Yep this is happening to me as well. Just when upgrading to 1.4.0

sh...@venturedive.com <sh...@venturedive.com> #22May 3, 2023 04:59AM

I just want to ask when the fix is available to use in Jetpack Compose without any hack and in which version of Jetpack Compose?

st...@google.com <st...@google.com> #23May 3, 2023 12:17PM

As per #16 this is fixed in Compose UI 1.4.2, and BOM 2023.04.01. TY

ed...@gmail.com <ed...@gmail.com> #24May 5, 2023 11:57AM

I can confirm that is still not working with compose UI 1.4.2 and BOM 2023.04.01

st...@google.com <st...@google.com> #25May 5, 2023 12:22PM

Tested with code provided in #5. Tapping the TextField in the dialog opens the keyboard on Compose 1.4.2 ok. What are you observing? Maybe you can share your min repro? TY.

an...@gmail.com <an...@gmail.com> #26May 5, 2023 12:22PM

And I can confirm that it does not work even with BOM 2023.05.00.
Such a serious bug and nobody pays normal attention to it.
there is a hack described in this post

https://patrykkosieradzki.com/how-to-fix-keyboard-issues-introduced-in-the-latest-jetpack-compose-1-4-0/

for now I use this approach, but I really hope that someone from Google will eventually fix this frustrating bug.

ja...@gmail.com <ja...@gmail.com> #27May 5, 2023 03:14PM

Hi,

keyboard was shown properly in compose 1.4.3 but in 1.5.0-alpha03 it stopped working again.

In 1.4.3 and 1.5.0-alpha03 now i have following issue which causing app crash.

1 @main: CRASH DETECTED on thread Thread[main,5,main]
 E  java.lang.IllegalStateException: LayoutCoordinate operations are only valid when isAttached is true
 E  	at androidx.compose.ui.node.NodeCoordinator.localToRoot-MK-Hz9U(NodeCoordinator.kt:850)
 E  	at androidx.compose.foundation.text.TextFieldDelegate$Companion.notifyFocusedRect$foundation_release(TextFieldDelegate.kt:173)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.notifyFocusedRect(CoreTextField.kt:1111)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.notifyTextInputServiceOnFocusChange(CoreTextField.kt:962)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.access$notifyTextInputServiceOnFocusChange(CoreTextField.kt:1)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$focusModifier$1.invoke(CoreTextField.kt:293)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$focusModifier$1.invoke(CoreTextField.kt:282)
 E  	at androidx.compose.ui.focus.FocusChangedModifierNode.onFocusEvent(FocusChangedModifier.kt:59)
 E  	at androidx.compose.ui.focus.FocusEventModifierNodeKt.refreshFocusEventNodes(FocusEventModifierNode.kt:68)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.requestFocusForChild(FocusTransactions.kt:208)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.performRequestFocus(FocusTransactions.kt:69)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.requestFocus(FocusTransactions.kt:44)
 E  	at androidx.compose.ui.focus.FocusRequester.focus$ui_release(FocusRequester.kt:72)
 E  	at androidx.compose.ui.focus.FocusRequester.requestFocus(FocusRequester.kt:63)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.tapToFocus(CoreTextField.kt:939)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.access$tapToFocus(CoreTextField.kt:1)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$pointerModifier$1.invoke-k-4lQ0M(CoreTextField.kt:342)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$pointerModifier$1.invoke(CoreTextField.kt:341)
 E  	at androidx.compose.foundation.text.TextFieldPressGestureFilterKt$tapPressTextFieldModifier$1$2$2.invoke-k-4lQ0M(TextFieldPressGestureFilter.kt:81)
 E  	at androidx.compose.foundation.text.TextFieldPressGestureFilterKt$tapPressTextFieldModifier$1$2$2.invoke(TextFieldPressGestureFilter.kt:54)
 E  	at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1.invokeSuspend(TapGestureDetector.kt:255)
 E  	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
 E  	at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
 E  	at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:672)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.dispatchPointerEvent(SuspendingPointerInputFilter.kt:548)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:570)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:314)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:301)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:301)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:301)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:301)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:301)
 E  	at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:183)
 E  	at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:102)
 E  	at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:98)
 E  	at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1371)
 E  	at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1323)
 E  	at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1263)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:500)
 E  	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1905)
 E  	at android.app.Dialog.dispatchTouchEvent(Dialog.java:911)
 E  	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
 E  	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:458)
 E  	at android.view.View.dispatchPointerEvent(View.java:15262)
 E  	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6654)
 E  	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6454)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5910)
 E  	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5967)
 E  	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5933)
 E  	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6098)
 E  	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5941)
 E  	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6155)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5914)
 E  	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5967)
 E  	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5933)
 E  	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5941)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5914)
 E  	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8996)
 E  	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8947)
 E  	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8916)
 E  	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9119)
 E  	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:267)
 E  	at android.os.MessageQueue.nativePollOnce(Native Method)
 E  	at android.os.MessageQueue.next(MessageQueue.java:335)
 E  	at android.os.Looper.loopOnce(Looper.java:161)
 E  	at android.os.Looper.loop(Looper.java:288)
 E  	at android.app.ActivityThread.main(ActivityThread.java:7872)
 E  	at java.lang.reflect.Method.invoke(Native Method)
 E  	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
 E  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
 E  	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@a05fbf2, androidx.compose.runtime.BroadcastFrameClock@67c3243, StandaloneCoroutine{Cancelling}@d0400c0, AndroidUiDispatcher@76f01f9]

Steps to reproduce should be quite simple. Just create some BottomSheetDialogFragment which will have compose view inside and in that compose view you should have some TextInputs. Also im using FocusRequester in that compose screen.

In compose 1.4.3 - keyboard was shown properly when i clicked into text inputs there BUT if i clicked on some input which was partially hidden under keyboard it caused crash (see stacktrace above). In compose 1.5.0-alpha03 - keyboard is not showing when i clicked into some text input - instead it will just do that crash (see stacktrace above).

This issue occur on Samsung S23 and also on emulator.

I think its related to https://issuetracker.google.com/issues/215116019

Please act urgently and increase this ticket priority because its important issue. Thanks

ed...@gmail.com <ed...@gmail.com> #28May 5, 2023 05:25PM

I can easily reproduce it by using the ModalBottomSheetSample from this site

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt.

I am using BOM 2023.04.01. No matter which version I use for androidx.compose.ui it does not work.
I am wondering whether there is some other dependency overriding the fix in a way that is does not work.

su...@gmail.com <su...@gmail.com> #29May 5, 2023 05:32PM

Same issue here, updated to 1.4.3
when using the emulator, keyboard doesn't show up until you start typing using the hardware keyboard

ro...@google.com <ro...@google.com> May 10, 2023 03:42PM

Status: Assigned (reopened)

si...@google.com <si...@google.com> #30May 10, 2023 05:05PM

P1 since it is reported to be a regression.

se...@google.com <se...@google.com> #31May 10, 2023 11:44PM

First, prioritizing this as a regression for 1.5 and adding to burndown list. Lets get this sorted.

Second, the fix in this bug is only included in:

Patch release: 1.4.3
Alpha release: 1.5.0-alpha04

It was not included in 1.5.0-alpha03 as it didn't make the release cut.

In compose 1.4.3 - keyboard was shown properly when i clicked into text inputs there BUT if i clicked on some input which was partially hidden under keyboard it caused crash (see stacktrace above).

Thank you!

Can you share a minimal repro against 1.4.3 or 1.5.0-alpha04 with repro steps help expedite the fix.

Thanks!

ja...@gmail.com <ja...@gmail.com> #32May 11, 2023 08:43AM

I tried version 1.5.0-alpha04 - keyboard is shown properly in that dialog but there is still that crash below (but its related to https://issuetracker.google.com/issues/215116019 i guess). Currently im able to reproduce that issue when i have multiple textinputs in that dialog - i click on first input, keyboard is shown up, i click into last one textinput, then i click into first input again and crash occur.

 E  	at androidx.compose.ui.node.NodeCoordinator.localToRoot-MK-Hz9U(NodeCoordinator.kt:844)
 E  	at androidx.compose.foundation.text.TextFieldDelegate$Companion.notifyFocusedRect$foundation_release(TextFieldDelegate.kt:173)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.notifyFocusedRect(CoreTextField.kt:1111)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.notifyTextInputServiceOnFocusChange(CoreTextField.kt:962)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.access$notifyTextInputServiceOnFocusChange(CoreTextField.kt:1)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$focusModifier$1.invoke(CoreTextField.kt:293)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$focusModifier$1.invoke(CoreTextField.kt:282)
 E  	at androidx.compose.ui.focus.FocusChangedModifierNode.onFocusEvent(FocusChangedModifier.kt:59)
 E  	at androidx.compose.ui.focus.FocusEventModifierNodeKt.refreshFocusEventNodes(FocusEventModifierNode.kt:68)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.requestFocusForChild(FocusTransactions.kt:208)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.performRequestFocus(FocusTransactions.kt:69)
 E  	at androidx.compose.ui.focus.FocusTransactionsKt.requestFocus(FocusTransactions.kt:44)
 E  	at androidx.compose.ui.focus.FocusRequester.focus$ui_release(FocusRequester.kt:72)
 E  	at androidx.compose.ui.focus.FocusRequester.requestFocus(FocusRequester.kt:63)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.tapToFocus(CoreTextField.kt:939)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.access$tapToFocus(CoreTextField.kt:1)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$pointerModifier$1.invoke-k-4lQ0M(CoreTextField.kt:342)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$pointerModifier$1.invoke(CoreTextField.kt:341)
 E  	at androidx.compose.foundation.text.TextFieldPressGestureFilterKt$tapPressTextFieldModifier$1$2$2.invoke-k-4lQ0M(TextFieldPressGestureFilter.kt:81)
 E  	at androidx.compose.foundation.text.TextFieldPressGestureFilterKt$tapPressTextFieldModifier$1$2$2.invoke(TextFieldPressGestureFilter.kt:54)
 E  	at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1.invokeSuspend(TapGestureDetector.kt:255)
 E  	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
 E  	at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
 E  	at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
 E  	at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:670)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.dispatchPointerEvent(SuspendingPointerInputFilter.kt:546)
 E  	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:568)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:317)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
 E  	at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
 E  	at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:183)
 E  	at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:102)
 E  	at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:96)
 E  	at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1376)
 E  	at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1328)
 E  	at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1268)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
 E  	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
 E  	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:500)
 E  	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1905)
 E  	at android.app.Dialog.dispatchTouchEvent(Dialog.java:911)
 E  	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
 E  	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:458)
 E  	at android.view.View.dispatchPointerEvent(View.java:15262)
 E  	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6654)
 E  	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6454)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5910)
 E  	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5967)
 E  	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5933)
 E  	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6098)
 E  	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5941)
 E  	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6155)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5914)
 E  	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5967)
 E  	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5933)
 E  	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5941)
 E  	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5914)
 E  	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8996)
 E  	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8947)
 E  	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8916)
 E  	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9119)
 E  	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:267)
 E  	at android.os.MessageQueue.nativePollOnce(Native Method)
 E  	at android.os.MessageQueue.next(MessageQueue.java:335)
 E  	at android.os.Looper.loopOnce(Looper.java:161)
 E  	at android.os.Looper.loop(Looper.java:288)
 E  	at android.app.ActivityThread.main(ActivityThread.java:7872)
 E  	at java.lang.reflect.Method.invoke(Native Method)
 E  	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
 E  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
 E  	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@dc5dd85, androidx.compose.runtime.BroadcastFrameClock@9c07da, StandaloneCoroutine{Cancelling}@96ff40b, AndroidUiDispatcher@c8872e8]```

se...@google.com <se...@google.com> #33May 11, 2023 03:53PM

Marked as fixed.

Thanks, we've split the TextField bits of b/215116019 to b/281984756 please put future updates there.

From my testing it looks like the relevant keyboard ime for this ticket is now fixed, and a new bug (b/281984756) has surfaced that we are also tracking for 1.5 release.

I will close this ticket if the only issue currently is the crash caused by !isAttached which is now tracked in a new bug.

If anyone has a repro other than the following crash, please comment and will re-open.

Crash below now tracked in b/281984756

1 @main: CRASH DETECTED on thread Thread[main,5,main]
 E  java.lang.IllegalStateException: LayoutCoordinate operations are only valid when isAttached is true
 E  	at androidx.compose.ui.node.NodeCoordinator.localToRoot-MK-Hz9U(NodeCoordinator.kt:850)
 E  	at androidx.compose.foundation.text.TextFieldDelegate$Companion.notifyFocusedRect$foundation_release(TextFieldDelegate.kt:173)
 E  	at androidx.compose.foundation.text.CoreTextFieldKt.notifyFocusedRect(CoreTextField.kt:1111)

ed...@gmail.com <ed...@gmail.com> #34May 16, 2023 11:20AM

Thank you. Keyboard is now showing with version 1.5.0-alpha04.

ju...@google.com <ju...@google.com> #35May 24, 2023 07:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-android:1.2.0-alpha02

ri...@gmail.com <ri...@gmail.com> #36Jul 17, 2023 12:10PM

Comment has been deleted.

Message last modified on Jul 17, 2023 12:49PM

sa...@gmail.com <sa...@gmail.com> #37Feb 13, 2024 06:44AM

Hello.
I encountered the problem described above on devices with API 28 (emulator and real device). When receiving focus on a TextField(BasicTextField) inside a ModalBottomSheet that is called from a BottomSheetDialogFragment, the keyboard does not appear.
I tried using the hack described above, but it doesn't work.
The latest BOM version is currently 2024.02.00.

Message last modified on Feb 13, 2024 08:28AM

mt...@gmail.com <mt...@gmail.com> #38Feb 17, 2024 10:24PM

With Compose BOM Version 2024.02.00, the keyboard is still not showing in a DialogFragment, where ComposeView is used from within onCreateDialog with AlertDialog.Builder.setView as described in https://issuetracker.google.com/issues/194754697 .

ha...@sina.com <ha...@sina.com> #39Jun 8, 2024 01:18PM

bug still happen with compose bom version 2024.05.00

、、、

java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.WindowInsetsController com.android.internal.policy.DecorView.getWindowInsetsController()' on a null object reference at com.android.internal.policy.PhoneWindow.getInsetsController(PhoneWindow.java:3930) at androidx.core.view.WindowInsetsControllerCompat$Impl30.<init>(WindowInsetsControllerCompat.java:613) at androidx.core.view.WindowInsetsControllerCompat.<init>(WindowInsetsControllerCompat.java:102) at androidx.compose.ui.text.input.ImmHelper30.getInsetsControllerCompat(InputMethodManager.kt:133) at androidx.compose.ui.text.input.ImmHelper30.hideSoftInput(InputMethodManager.kt:152) at androidx.compose.ui.text.input.InputMethodManagerImpl.hideSoftInput(InputMethodManager.kt:83) at androidx.compose.ui.text.input.TextInputServiceAndroid.setKeyboardVisibleImmediately(TextInputServiceAndroid.android.kt:397) at androidx.compose.ui.text.input.TextInputServiceAndroid.processInputCommands(TextInputServiceAndroid.android.kt:302) at androidx.compose.ui.text.input.TextInputServiceAndroid.sendInputCommand$lambda$1(TextInputServiceAndroid.android.kt:209) at androidx.compose.ui.text.input.TextInputServiceAndroid.$r8$lambda$tFIm8sXGny3G873nGUe23EJe7OY(Unknown Source:0) at androidx.compose.ui.text.input.TextInputServiceAndroid$$ExternalSyntheticLambda0.run(Unknown Source:2) at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt.asExecutor$lambda$1$lambda$0(TextInputServiceAndroid.android.kt:504) at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt.$r8$lambda$RYljF3nl5HRu6JKEM8xFRHwbGFg(Unknown Source:0) at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt$$ExternalSyntheticLambda0.doFrame(Unknown Source:2) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239) at android.view.Choreographer.doCallbacks(Choreographer.java:899) at android.view.Choreographer.doFrame(Choreographer.java:827) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214) at android.os.Handler.handleCallback(Handler.java:942) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7872) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

、、、

di...@gmail.com <di...@gmail.com> #40Nov 1, 2024 05:13PM

This bug is still present in BOM 2024.10.00

li...@gmail.com <li...@gmail.com> #41Nov 28, 2024 05:27AM

still cannot work as #40

Message last modified on Nov 28, 2024 05:48AM