Macrobenchmark runs without suppressing on ARM Pixel Emulator [262209591]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 12, 2022 11:15AM

Version used: 1.2.0-alpha08

Devices/Android versions reproduced on: ARM Emulator Pixel 3A API 33 userdebug (without Google Play)

The isEmulator property doesn't recognize this as emulator and Macrobenchmark runs without suppressing.

Build.FINGERPRINT = google/sdk_gphone64_arm64/emu64a:13/TPB4.220624.004/8808248:userdebug/dev-keys
Build.MODEL = sdk_gphone64_arm64
Build.MANUFACTURER = Google
Build.BRAND = google
Build.PRODUCT = sdk_gphone64_arm64

We had a similar bug b/231535257 already.

Comments

ma...@google.com <ma...@google.com> Dec 12, 2022 09:14PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Jan 5, 2023 12:44AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 69133b2c7390cb0a2f242737223f61ed0497deb2
Author: Marcello Albano <maralb@google.com>
Date: Mon Dec 12 13:23:24 2022

Fixed isEmulator check for arm emulator api 33

Fix: 262209591
Test: ./gradlew bench:b-m:cC
Change-Id: Iae0710d7096b65770f0b5b6dd95992b72219604a

M benchmark/benchmark-common/src/main/java/androidx/benchmark/DeviceInfo.kt

https://android-review.googlesource.com/2344757

ma...@google.com <ma...@google.com> Jan 5, 2023 12:58AM

Marked as fixed.

Issue 262209591

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Dec 12, 2022 09:14PM

ap...@google.com <ap...@google.com> #2Jan 5, 2023 12:44AM

ma...@google.com <ma...@google.com> Jan 5, 2023 12:58AM

Add comment

Issue metadata