Marquee should continue to animate even when animation is disabled [262298306]

Fixed

Feature Request

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Dec 12, 2022 11:54PM

Marquee is effectively just a scrolling animation for text. When motion is set to be reduced in the a11y settings, we typically disable animations altogether. However, for marquee, the animation isn't just there to look pretty, it's required to show the full text. So how should marquee respond to reduced motion?

Discussion in design doc.

Comments

ou...@google.com <ou...@google.com> #2Jan 3, 2023 07:10PM

Following CLs are added to AndroidX:
-

https://r.android.com/2193004
-

https://r.android.com/2186213
-

https://r.android.com/2232128

kl...@google.com <kl...@google.com> #3Jan 3, 2023 10:22PM

Chromium counterpart:

https://crbug.com/1355297

kl...@google.com <kl...@google.com> Jan 11, 2023 09:35PM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #4Jan 12, 2023 12:29AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a0fc2a2e7b8c8c09e36202915d836e67c3312253
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Oct 03 13:11:02 2022

Add test for ProcessGlobalConfigActivity

Test ensures that there exists a data directory present on the device
with the name specified using `setDataDirectorySuffix(String, Context)`.

Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ic1391ac6527fa78464ed4c9f685a067d6dcb3dc1

A webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
A webkit/integration-tests/testapp/src/main/res/layout/activity_process_global_config.xml
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2239836

pr...@google.com <pr...@google.com> #5Jan 25, 2023 09:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit e59d4c20268f10741b4bfb0d939884704659043c
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Oct 25 13:58:31 2022

Unhide ProcessGlobalConfig APIs

Along with unhiding the APIs, the API files are also updated.

Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687
Relnote: "Add ProcessGlobalConfig enabling users to set process global
config prior to loading WebView."

Change-Id: I7c0e0e42e91efe45f16e66afead7b9e52240bfe4

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/webkit/api/current.txt
M webkit/webkit/api/public_plus_experimental_current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2268927

Issue 262298306