Fixed
Status Update
Comments
ou...@google.com <ou...@google.com> #2
When a "reduced animation" setting is toggled by the user, the feature typically does not remove 100% of the animations in the UI. It reduces motions and animations on high-use surfaces. These animations and motions should not restrict or remove access to information, like the example in comment#1 .
The suggested behavior is that the marquee remains as-is even when a reduced animation feature is turned on.
The suggested behavior is that the marquee remains as-is even when a reduced animation feature is turned on.
kl...@google.com <kl...@google.com> #3
The current implementation of Compose marquee will not animate when animations are disabled, so I'll treat this as a bug and fix.
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes: b/262298306
Bug: b/265177763
Test: manually
Test: Not possible to test yet, see b/265177763 . But ignored test added
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2382936
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes:
Bug:
Test: manually
Test: Not possible to test yet, see
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha05
Description
Marquee is effectively just a scrolling animation for text. When motion is set to be reduced in the a11y settings, we typically disable animations altogether. However, for marquee, the animation isn't just there to look pretty, it's required to show the full text. So how should marquee respond to reduced motion?
Discussion in design doc .