Fixed
Status Update
Comments
ou...@google.com <ou...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
kl...@google.com <kl...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes: b/262298306
Bug: b/265177763
Test: manually
Test: Not possible to test yet, see b/265177763 . But ignored test added
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2382936
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes:
Bug:
Test: manually
Test: Not possible to test yet, see
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha05
Description
Marquee is effectively just a scrolling animation for text. When motion is set to be reduced in the a11y settings, we typically disable animations altogether. However, for marquee, the animation isn't just there to look pretty, it's required to show the full text. So how should marquee respond to reduced motion?
Discussion in design doc .