Fixed
Status Update
Comments
ha...@google.com <ha...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit f0b9564f0ea8b13dc46d0b021c86389bb95535a1
Author: Halil Ozercan <halilibo@google.com>
Date: Thu Aug 31 14:38:10 2023
Stabilize Magnifier APIs
- Remove `MagnifierStyle` and inline all its parameters to `Modifier.magnifier()`.
- Remove `fishEyeEnabled` for lack of support, will reconsider in the future.
- Keep `useTextDefault` internal since it is not clear whether it affects anything on API 28, leaving it as future work. b/298381260
Fix: b/262367109
Fix: b/261438887
Test: existing Magnifier tests
Relnote: "Stabilized `Modifier.magnifier()` and removed `MagnifierStyle` while inlining all its parameters to modifier itself."
Change-Id: I83bec09bc5ec419cb007d6f1e1340fba99f122d6
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/MagnifierDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/MagnifierSamples.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/MagnifierTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/PlatformMagnifierTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/Magnifier.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/PlatformMagnifier.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/selection/AndroidTextFieldMagnifier.kt
https://android-review.googlesource.com/2735833
Branch: androidx-main
commit f0b9564f0ea8b13dc46d0b021c86389bb95535a1
Author: Halil Ozercan <halilibo@google.com>
Date: Thu Aug 31 14:38:10 2023
Stabilize Magnifier APIs
- Remove `MagnifierStyle` and inline all its parameters to `Modifier.magnifier()`.
- Remove `fishEyeEnabled` for lack of support, will reconsider in the future.
- Keep `useTextDefault` internal since it is not clear whether it affects anything on API 28, leaving it as future work.
Fix:
Fix:
Test: existing Magnifier tests
Relnote: "Stabilized `Modifier.magnifier()` and removed `MagnifierStyle` while inlining all its parameters to modifier itself."
Change-Id: I83bec09bc5ec419cb007d6f1e1340fba99f122d6
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/MagnifierDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/MagnifierSamples.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/MagnifierTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/PlatformMagnifierTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/Magnifier.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/PlatformMagnifier.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/selection/AndroidTextFieldMagnifier.kt
na...@google.com <na...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.6.0-alpha06
androidx.compose.foundation:foundation-android:1.6.0-alpha06
Description
Migration guide:https://docs.google.com/document/d/1W54Nw7d6TGF20aZzZkt1O57an9ELK6juHC81kNPPqSI/edit#heading=h.31rhp28omnv0