Lint SDK_INT checks should understand temporary local variables [262376528]

Fixed

Bug

Status Update

No update yet.

Description

tn...@google.com

created issue #1

Dec 13, 2022 02:47PM

I ran lint on a test project and got some API errors. It turns out that the code is properly checking for the SDK_INT level, but it stores this in an intermediate local variable.

Lint looks for SDK_INTs stored in fields and checked by utility methods, but not intermediate local variables.

Example: the "dynamicColor" variable in https://github.com/code-with-the-italians/bundel/blob/main/app/src/main/java/dev/sebastiano/bundel/ui/Theme.kt#L23

Build: AI-222.4345.14.2221.9321504, 202211222246, 

AI-222.4345.14.2221.9321504, JRE 17.0.4.1+0-17.0.4.1b469.62-9127311x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.6.1, screens 3456.0x2234.0; Retina

AS: Flamingo | 2022.2.1 Canary 9
Kotlin plugin: 222-1.7.21-release-AS3739.54
Android Gradle Plugin: 8.0.0-alpha09
Gradle: 7.5
Gradle JDK: version 17.0.4
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: 3.10.2, from PATH: (not found)


IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

tn...@google.com <tn...@google.com> Dec 13, 2022 03:01PM

Accepted by tn...@google.com.

tn...@google.com <tn...@google.com> #2Dec 14, 2022 07:47PM

Retraced stack trace:

Caused by: java.lang.UnsupportedOperationException: Operation is not supported for read-only collection
	at com.android.tools.r8.jetbrains.kotlin.collections.EmptyList.removeAll(Collections.kt)
	at com.android.tools.r8.resourceshrinker.r8integration.LegacyResourceShrinker.run(LegacyResourceShrinker.java:228)
	at com.android.tools.r8.R8.shrinkResources(R8.java:991)
	at com.android.tools.r8.R8.runInternal(R8.java:894)
	at com.android.tools.r8.R8.runInternal(R8.java:259)
	at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
	at com.android.tools.r8.internal.Nu.a(R8_8.9.27_3afcc9fea5cc5cd06373667ec09d5fe106db8a4a77576689534e667542385a93:28

se...@google.com <se...@google.com> #3Dec 15, 2022 10:10AM

This is happening when there are no unused resources at all and we have duplicated resources between the feature and base (or different features)

Reproduction here: https://r8-review.git.corp.google.com/c/r8/+/102418

Fix here: https://r8-review.git.corp.google.com/c/r8/+/102626

For the reporter to work around this:

Disable resource shrinking in this case, it will have no effect since there are no unused resources for this build
Use legacy AGP embedded shrinker - set android.r8.integratedResourceShrinking false in your settings
Manually update to a new R8 version (I will post a follow up when this is on our release branch)

tn...@google.com <tn...@google.com> Dec 16, 2022 04:15PM

Marked as fixed.

Issue 262376528

Description

Issue summary

Comments

tn...@google.com <tn...@google.com> Dec 13, 2022 03:01PM

tn...@google.com <tn...@google.com> #2Dec 14, 2022 07:47PM

se...@google.com <se...@google.com> #3Dec 15, 2022 10:10AM

tn...@google.com <tn...@google.com> Dec 16, 2022 04:15PM

Add comment

Issue metadata