IllegalArgumentException in MultiParagraph [262411189]

Assigned

Bug

Status Update

No update yet.

Description

se...@gmail.com

created issue #1

Dec 13, 2022 11:45PM

Jetpack Compose version: 1.3.1
Jetpack Compose component used: OutlinedTextField
Android Studio Build: Android Studio Electric Eel | 2022.1.1 RC 1
Kotlin version: 1.7.10
Devices/Android versions reproduced on: Pixel 2 Android 11
Keyboard (i.e. Gboard, Samsung, etc): Google

This is intermittent so we have not been able to produce a sample project yet. It happens with the original project with a Pixel 2 Android 11 and otherwise on production devices. Can't share the video because its internal to the company, but repro steps are explained below.

The hierarchy is: BottomSheetDialogFragment -> Fragment -> ComposeView -> and we do setViewCompositionStrategy(DisposeOnViewTreeLifecycleDestroyed) as well.

The ComposeView has the following content:

@OptIn(ExperimentalComposeUiApi::class)
@Composable
private fun EditorContent(
    content: Content,
    uiParams: UIParams,
    notifyEvent: (UIEvent) -> Unit,
    modifier: Modifier
) {
    val textState = remember {
        mutableStateOf(
          TextFieldValue(
            text = uiParams.newInput, 
            selection = TextRange(uiParams.newInput.length)
          )
        )
    }
    val oldInput = textState.value
    val newInput = if (oldInput.text == uiParams.newInput) {
        oldInput
    } else {
        oldInput.copy(text = uiParams.newInput).also { textState.value = it }
    }
    val focusRequester = remember { FocusRequester() }
    val keyboard = LocalSoftwareKeyboardController.current
    Column(modifier = modifier) {
        EditorHeader(content, uiParams, notifyEvent)
        if (uiParams.flavor == PROMPT_A) {
            SelectionCard(selectionTitle = uiParams.selection.text, notifyEvent = notifyEvent)
            FormInputA(
                newInput = newInput,
                onValueChange = { newText ->
                    textState.value = newText
                    notifyEvent(UIEvent.Update(newText.text))
                },
                modifier = modifier,
                placeHolderText = content.backgroundText,
                focusRequester = focusRequester
            )
        } else if (uiParams.flavor == PROMPT_B) {
            FormInputB(
                newInput = newInput,
                onValueChange = { newText ->
                    textState.value = newText
                    notifyEvent(UIEvent.Update(newText.text))
                },
                modifier = modifier,
                placeHolderText = content.backgroundText,
                labelText = content.textBoxHeader,
                focusRequester = focusRequester
            )
        }
        TextCounter(charsLeftMessage = uiParams.charCounterMessage)
        if (uiParams.flavor == PROMPT_B) {
            ListSelectionButton(title = content.buttonSecondaryText, notifyEvent = notifyEvent)
        }
        LaunchedEffect(focusRequester) {
            focusRequester.requestFocus()
            delay(KEYBOARD_DELAY)
            keyboard?.show()
        }
    }
}

Where OutlinedTextField is used in the FormInputA/B composables.

Stack trace:

java.lang.IllegalArgumentException: offset(11) is out of bounds [0, 10]
  at androidx.compose.ui.text.MultiParagraph.requireIndexInRangeInclusiveEnd(MultiParagraph.kt:756)
  at androidx.compose.ui.text.MultiParagraph.getCursorRect(MultiParagraph.kt:605)
  at androidx.compose.ui.text.TextLayoutResult.getCursorRect(TextLayoutResult.kt:547)
  at androidx.compose.foundation.text.TextFieldCursorKt$cursor$1$2.invoke(TextFieldCursor.kt:60)
  at androidx.compose.foundation.text.TextFieldCursorKt$cursor$1$2.invoke(TextFieldCursor.kt:54)                                                                                             	at androidx.compose.ui.draw.DrawWithContentModifier.draw(DrawModifier.kt:266)
	at androidx.compose.ui.node.BackwardsCompatNode.draw(BackwardsCompatNode.kt:381)

Repro steps:

Open bottom sheet dialog
Type text in text field
Move the cursor around/delete the text
Crashes

I could be related to https://issuetracker.google.com/issues/262411188 because sometimes we see that exception and sometimes we see this IllegalArgumentException.

Please see full trace attached.

IAE-out-of-bounds.txt

5.5 KB

View

Download

Comments

ha...@google.com <ha...@google.com> #2Dec 28, 2022 02:00PM

Hello, thanks for reporting this. I see the stacktrace goes through a VisualTransformation path. It doesn't necessarily mean that you are using a VisualTransformation but it's relatively rarer to hit this kind of a crash using an Identity VisualTransformation.

Also, it's very difficult to reason in terms of what this screen represents without knowing much about FormInputA, FormInputB, ListSelectionButton, etc. It'd be really nice to have more context with respect to how much you can share.

In any case, we will definitely look into BottomSheetDialogFragment -> Fragment -> ComposeView hierarchy.

se...@gmail.com <se...@gmail.com> #3Jan 8, 2023 06:06AM

Thanks for taking a look. Here's a few more details about the FormInputA, FormInputB, & ListSelectionButton composables:

Both inputs are pretty similar (using OutlinedTextField):

fun FormInputA(
    input: TextFieldValue,
    onValueChange: (TextFieldValue) -> Unit,
    modifier: Modifier = Modifier,
    placeHolderText: String,
    focusRequester: FocusRequester
) {
    OutlinedTextField(
        value = input,
        placeholder = { TextFieldPlaceHolder(title = placeHolderText) },
        onValueChange = onValueChange,
        textStyle = TextStyles.heading.copy(textAlign = TextAlign.Left),
        modifier = modifier
            .defaultMinSize(minHeight = 250.dp)
            .fillMaxWidth()
            .focusRequester(focusRequester)
            .background(Colors.background),
        colors = TextFieldDefaults.outlinedTextFieldColors(
            /** bunch of colors **/
        )
    )
}

@Composable
fun FormInputB(
    input: TextFieldValue,
    onValueChange: (TextFieldValue) -> Unit,
    modifier: Modifier = Modifier,
    placeHolderText: String,
    labelText: String,
    focusRequester: FocusRequester
) {
    OutlinedTextField(
        value = input,
        label = { TextFieldLabel(title = labelText) },
        placeholder = { TextFieldPlaceHolder(title = placeHolderText) },
        onValueChange = onValueChange,
        textStyle = TextStyles.heading.copy(textAlign = TextAlign.Left),
        modifier = modifier
            .defaultMinSize(minHeight = 200.dp)
            .fillMaxWidth()
            .focusRequester(focusRequester)
            .background(Colors.background),
        colors = TextFieldDefaults.outlinedTextFieldColors(
            /** bunch of colors **/
        )
    )
}

The ListSelectionButton is a Row with a custom button whose main moving parts are shown here (not able to share the full code):

@Composable
fun ListSelectionButton(
    modifier: Modifier = Modifier,
    text: String,
    notifyEvent: (Event) -> Unit
) {
    Row(
        verticalAlignment = Alignment.CenterVertically,
        horizontalArrangement = Arrangement.Center,
        modifier = Modifier.fillMaxWidth()
    ) {
        CustomButton(
            text = text,
            onClick = { notifyEvent(Event.Clicked) },
            modifier = modifier
                .wrapContentHeight()
                .padding(top = 40.dp, bottom = 24.dp)
        )
    }
}

@composable
fun CustomButton(
  onClick: () -> Unit, 
  text: String, 
  isLoading: Boolean,
  modifier: Modifier
) {
  Surface(modifier) {
    Row {
      if (isLoading) {
        CircularProgressIndicator()
      } else {
        Text(text)
      }
    }
  }
}

Let me know if there are any other details that could help, will try to share if possible.

se...@gmail.com <se...@gmail.com> #4Jul 9, 2024 06:20PM

Hi all - wondering if there was any movement on this. We are currently on Compose BOM 2023.10.01 and it is still happening.

Issue 262411189

Description

Issue summary

Comments

ha...@google.com <ha...@google.com> #2Dec 28, 2022 02:00PM

se...@gmail.com <se...@gmail.com> #3Jan 8, 2023 06:06AM

se...@gmail.com <se...@gmail.com> #4Jul 9, 2024 06:20PM

Add comment

Issue metadata