Deprecate original LiveDataReactiveStreams.toPublisher() extension method [262623005]

Fixed

Feature Request

Status Update

No update yet.

Description

sa...@google.com

created issue #1

Dec 15, 2022 01:10AM

LiveDataReactiveStreams has been converted to kotlin and lifecycle-reactivestreams-ktx has been merged into lifecycle-reactivestreams as of this change (https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2324953). Since the LiveData.toPublisher() kotlin extension method has a different parameter ordering, we needed to keep the original LiveDataReactiveStreams.toPublisher() extension method. We should deprecate this method to point developers to the LiveData.toPublisher() kotlin extension method.

Comments

mr...@gmail.com <mr...@gmail.com> #2Sep 15, 2023 04:52AM

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

il...@google.com <il...@google.com> Sep 28, 2023 10:15PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> Jan 23, 2024 09:27PM

Reassigned to mg...@google.com.

ap...@google.com <ap...@google.com> #3Jan 31, 2024 11:15AM

Marked as fixed.

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

ap...@google.com <ap...@google.com> #4Jan 31, 2024 07:20PM

I also can't give parameters to the fragment being inflated.

pr...@google.com <pr...@google.com> #5Feb 21, 2024 07:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

Issue 262623005