Fixed
Status Update
No update yet.
Comments
mr...@gmail.com
Looks 0pne
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit a3165d405dac499323c0a073379333334e6cb294
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 10:59:19 2024
Deprecate `toPublisher(lifecycle, liveData)`
* Deprecated `LiveDataReactiveStreams.toPublisher` in favor of `LiveData.toPublisher`.
* Previously, `LiveDataReactiveStreams.toPublisher` was used by `Livedata.toPublisher` from the `-ktx` module. However, with the merging of the `-ktx` module back to the main module (see aosp/2324953), the method redundant.
RelNote: "Deprecated `LiveDataReactiveStreams.toPublisher(lifecycleOwner, liveData)` in favor of `LiveData.toPublisher(lifecycleOwner)`."
Fixes: 262623005
Test: LiveDataReactiveStreamsExtensionTest
Change-Id: Iabe2986767b85f5b55cdfe6c9a44e3809860a3c6
M lifecycle/lifecycle-reactivestreams/api/current.txt
M lifecycle/lifecycle-reactivestreams/api/restricted_current.txt
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
https://android-review.googlesource.com/2927697
Branch: androidx-main
commit a3165d405dac499323c0a073379333334e6cb294
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 10:59:19 2024
Deprecate `toPublisher(lifecycle, liveData)`
* Deprecated `LiveDataReactiveStreams.toPublisher` in favor of `LiveData.toPublisher`.
* Previously, `LiveDataReactiveStreams.toPublisher` was used by `Livedata.toPublisher` from the `-ktx` module. However, with the merging of the `-ktx` module back to the main module (see aosp/2324953), the method redundant.
RelNote: "Deprecated `LiveDataReactiveStreams.toPublisher(lifecycleOwner, liveData)` in favor of `LiveData.toPublisher(lifecycleOwner)`."
Fixes: 262623005
Test: LiveDataReactiveStreamsExtensionTest
Change-Id: Iabe2986767b85f5b55cdfe6c9a44e3809860a3c6
M lifecycle/lifecycle-reactivestreams/api/current.txt
M lifecycle/lifecycle-reactivestreams/api/restricted_current.txt
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 38d3f2ba9cf6a31f09f86b1673e90ac6f9125c13
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Jan 31 15:06:44 2024
Suppress deprecated warnings for toPublisher in LiveDataReactiveStreamsTest
* Addressed the deprecated `toPublisher` warnings introduced by aosp/2927697 in their tests.
* Retained the tests targeting the deprecated function to maintain coverage and relevance.
* Deprecated warnings are now suppressed in the relevant statements to prevent noise in the build logs.
Bug: 262623005
Test: Manual
Change-Id: I254b2d2c9b7e56c88c93b3bba279a351a73ec186
M lifecycle/lifecycle-reactivestreams/src/test/java/androidx/lifecycle/LiveDataReactiveStreamsTest.kt
https://android-review.googlesource.com/2940465
Branch: androidx-main
commit 38d3f2ba9cf6a31f09f86b1673e90ac6f9125c13
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Jan 31 15:06:44 2024
Suppress deprecated warnings for toPublisher in LiveDataReactiveStreamsTest
* Addressed the deprecated `toPublisher` warnings introduced by aosp/2927697 in their tests.
* Retained the tests targeting the deprecated function to maintain coverage and relevance.
* Deprecated warnings are now suppressed in the relevant statements to prevent noise in the build logs.
Bug: 262623005
Test: Manual
Change-Id: I254b2d2c9b7e56c88c93b3bba279a351a73ec186
M lifecycle/lifecycle-reactivestreams/src/test/java/androidx/lifecycle/LiveDataReactiveStreamsTest.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-reactivestreams:2.8.0-alpha02
Description
LiveDataReactiveStreamshas been converted to kotlin andlifecycle-reactivestreams-ktxhas been merged intolifecycle-reactivestreamsas of this change (LiveData.toPublisher()kotlin extension method has a different parameter ordering, we needed to keep the originalLiveDataReactiveStreams.toPublisher()extension method. We should deprecate this method to point developers to theLiveData.toPublisher()kotlin extension method.