[desugared library] AssertionError in DesugaredLibraryRetargeterSyntheticHelper.verifyKind [262692506]

Duplicate

of 266687543

Bug

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Dec 15, 2022 11:32AM

Build from https://github.com/Mygod/pogoplusle/commit/149dc603097fe0aa207fe4653edbdd59d1e3dba9 with main (0575b717d9fca82ae80f2f49bb83699f8b247d32) R8 using the following patch:

diff --git a/settings.gradle.kts b/settings.gradle.kts
index e27cf54..b49c20b 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -4,6 +4,18 @@ pluginManagement {
         google()
         mavenCentral()
     }
+    buildscript {
+        repositories {
+            mavenCentral()
+            maven {
+                url = uri("https://storage.googleapis.com/r8-releases/raw")
+            }
+        }
+        dependencies {
+            //classpath("com.android.tools:r8:8.1.4-dev")
+            classpath(files("/usr/local/google/home/sgjesse/prj/r8/r8/build/libs/r8.jar"))
+        }
+    }
 }
 dependencyResolutionManagement {
     repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)

and assertions enabled:

ANDROID_HOME=~/Android/Sdk ./gradlew :app:minifyGoogleReleaseWithR8 --no-daemon --stacktrace -Dorg.gradle.jvmargs=-ea

Hits the following AssertionError:

Caused by: java.lang.AssertionError
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.verifyKind(DesugaredLibraryRetargeterSyntheticHelper.java:109)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.emulatedInterfaceDispatchMethod(DesugaredLibraryRetargeterSyntheticHelper.java:120)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.lambda$buildInterfaceDispatchMethod$18(DesugaredLibraryRetargeterSyntheticHelper.java:237)
        at com.android.tools.r8.synthesis.SyntheticClassBuilder.addMethod(SyntheticClassBuilder.java:155)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.buildInterfaceDispatchMethod(DesugaredLibraryRetargeterSyntheticHelper.java:234)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.lambda$ensureEmulatedInterfaceDispatchMethod$15(DesugaredLibraryRetargeterSyntheticHelper.java:209)
        at com.android.tools.r8.synthesis.SyntheticItems.internalEnsureFixedClasspathClass(SyntheticItems.java:832)
        at com.android.tools.r8.synthesis.SyntheticItems.ensureFixedClasspathClass(SyntheticItems.java:861)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.ensureEmulatedInterfaceDispatchMethod(DesugaredLibraryRetargeterSyntheticHelper.java:205)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.ensureEmulatedHolderDispatchMethod(DesugaredLibraryRetargeterSyntheticHelper.java:151)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeter.lambda$computeNonStaticRetarget$1(DesugaredLibraryRetargeter.java:219)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeter$InvokeRetargetingResult.getNewInvokeTarget(DesugaredLibraryRetargeter.java:173)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeter.desugarInvoke(DesugaredLibraryRetargeter.java:102)
        at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeter.desugarInstruction(DesugaredLibraryRetargeter.java:81)
        at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.applyDesugaring(NonEmptyCfInstructionDesugaringCollection.java:320)
        at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.desugarInstruction(NonEmptyCfInstructionDesugaringCollection.java:286)
        at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.lambda$desugar$2(NonEmptyCfInstructionDesugaringCollection.java:223)
        at com.android.tools.r8.utils.ListUtils.flatMapSameType(ListUtils.java:33)
        at com.android.tools.r8.ir.desugar.NonEmptyCfInstructionDesugaringCollection.desugar(NonEmptyCfInstructionDesugaringCollection.java:219)
        at com.android.tools.r8.shaking.Enqueuer.lambda$desugar$117(Enqueuer.java:4093)
        at com.android.tools.r8.utils.ThreadUtils.lambda$processItems$5(ThreadUtils.java:77)
        at com.android.tools.r8.utils.ThreadUtils.lambda$processItems$7(ThreadUtils.java:102)
        at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$3(ThreadUtils.java:69)

The AssertionError does not happen on the 4.0 branch - but on main. This was discovered while debugging b/250634405.

Comments

cl...@google.com <cl...@google.com> #2Jan 4, 2023 08:53AM

It seems this is due to the machine specification being invalid in this set-up. I need to add tests for this and fix it.

ap...@google.com <ap...@google.com> #3Jan 5, 2023 01:44PM

Project: r8
Branch: main

commit 380cb13c7ec6c50d437f94e86d5e381423a42395
Author: Clément Béra <clementbera@google.com>
Date: Wed Jan 04 14:36:51 2023

Desugared lib: stabilize synthetic kind id

Stabilize synthetic kind ids across compiler version
for the synthetic types used in machine specification

Bug:

b/262692506

Change-Id: I9ab1671bcc0078c1367bd6d611c792da2211527a

M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/DesugaredLibrarySpecificationParser.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/machinespecification/DerivedMethod.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/machinespecification/MachineDesugaredLibrarySpecificationParser.java
A src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/machinespecification/MachineSyntheticKind.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/machinespecification/MultiAPILevelMachineDesugaredLibrarySpecificationJsonExporter.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/retargeter/DesugaredLibraryRetargeterSyntheticHelper.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/specificationconversion/HumanToMachineEmulatedInterfaceConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/desugaredlibrary/specificationconversion/HumanToMachineRetargetConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/itf/InterfaceDesugaringSyntheticHelper.java
M src/test/java/com/android/tools/r8/desugar/desugaredlibrary/specification/ConvertExportReadTest.java

https://r8-review.googlesource.com/75084

cl...@google.com <cl...@google.com> #4Jan 12, 2023 06:39AM

Marked as fixed.

this should be fixed and backward compatible.

cl...@google.com <cl...@google.com> Feb 6, 2023 01:06PM

Status: Duplicate of

266687543

Issue 262692506

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> #2Jan 4, 2023 08:53AM

ap...@google.com <ap...@google.com> #3Jan 5, 2023 01:44PM

cl...@google.com <cl...@google.com> #4Jan 12, 2023 06:39AM

cl...@google.com <cl...@google.com> Feb 6, 2023 01:06PM

Add comment

Issue metadata