TypedArray#close (API 31) not desugared but AS does not display warning when used in try-with-resources [262851206]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

Dec 17, 2022 01:43PM

Using: AS 2022.2.1 Canary 9, com.android.tools:desugar_jdk_libs:2.0.0, AGP 8.0.0-alpha09

Code below does not cause AS to show any warning that it is API 31+ only when TypedArray#close is invoked as part of a try-with-resources block:

	try (TypedArray array = ...) {
        {
        } // TypedArray#close implicitly called, crash on API < 31

In fact, an IDE intention suggested that I converted my classic use to TypedArray (that is, calling TypedArray#release after use) to a try-with-resources block, which I did (since I saw no API warning I assumed it was either desugared or properly handled for all API levels by D8) only to see it crash on API < 31.

It would be nice to have this call desugared or AS not suggesting to use try-with-resources on minApiSdk < 31 (which is probably pretty much all apps currently).

Comments

pu...@gmail.com <pu...@gmail.com> #2Dec 17, 2022 01:46PM

Lint options:

    lintOptions {
        lintConfig = file('lint.xml')

        abortOnError true
        xmlReport true
        htmlReport true
        checkDependencies true
    }

Also, our project has custom lint rules. Failure happens with a dependency of 26.6.3 and 27.0.0.

Is any way to downgrade lint runner? This problem is keeping us from using AGP 4.0

ze...@google.com <ze...@google.com> Dec 19, 2022 08:11AM

Reassigned to cl...@google.com.

sg...@google.com <sg...@google.com> #3Dec 19, 2022 09:36AM

Reassigned to an...@google.com.

Attached slightly different stacktrace for the same problem.

Wonder if disabling some lint rules could help to "fix" this problem, as it is also blocking for us 4.0 AGP upgrade.

tn...@google.com <tn...@google.com> Dec 22, 2022 05:50PM

Reassigned to tn...@google.com.

sg...@google.com <sg...@google.com> #4Jan 4, 2023 02:13PM

Notes:

I suspect the exceptions are happening now because JetBrains recently changed an assert statement into a hard failure (see 3260e41111).

I.e., it's possible that Lint has been hitting this code path all along, and only now it is causing a problem.

This has been difficult to investigate so far because the failure is nondeterministic and also deep inside the Kotlin compiler. Plus, JetBrains seems to be hitting this code path occasionally too (hence why they changed the assert into a hard failure), so I'm not even sure whether Lint is implicated or not.

tn...@google.com <tn...@google.com> #5Jan 4, 2023 03:52PM

Marked as fixed.

It could also explain why not all lint rules were working from time to time (https://issuetracker.google.com/issues/149554597). According to Github, this change was done for 1.4-M2, which is considered unstable. Maybe lint runner could use an older but stable version? What else options do I have?

Is any public issue created I could follow?

sg...@google.com <sg...@google.com> #6Jan 4, 2023 04:05PM

Has anyone tried this with 4.1.0-beta2? We're using a more recent version of UAST and the Kotlin compiler there. It's not clear that it's fixed but -- there's a chance :-)

sa...@google.com <sa...@google.com> #7Jan 17, 2023 08:26PM

I tried. The same error. I am wondering, is any way to know which lint checks cause failure? I have a few custom lint checks. Or, is any way downgrade compiler for lint checks?