TypedArray#close (API 31) not desugared but AS does not display warning when used in try-with-resources [262851206]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

Dec 17, 2022 01:43PM

Using: AS 2022.2.1 Canary 9, com.android.tools:desugar_jdk_libs:2.0.0, AGP 8.0.0-alpha09

Code below does not cause AS to show any warning that it is API 31+ only when TypedArray#close is invoked as part of a try-with-resources block:

	try (TypedArray array = ...) {
        {
        } // TypedArray#close implicitly called, crash on API < 31

In fact, an IDE intention suggested that I converted my classic use to TypedArray (that is, calling TypedArray#release after use) to a try-with-resources block, which I did (since I saw no API warning I assumed it was either desugared or properly handled for all API levels by D8) only to see it crash on API < 31.

It would be nice to have this call desugared or AS not suggesting to use try-with-resources on minApiSdk < 31 (which is probably pretty much all apps currently).

Comments

pu...@gmail.com <pu...@gmail.com> #2Dec 17, 2022 01:46PM

I also have the same issue so it seems to be a real problem.

ze...@google.com <ze...@google.com> Dec 19, 2022 08:11AM

Reassigned to cl...@google.com.

sg...@google.com <sg...@google.com> #3Dec 19, 2022 09:36AM

Reassigned to an...@google.com.

Dup here:

http://code.google.com/p/android/issues/detail?id=27959&can=1&q=fixed%20position&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

Though it's a bit more detailed with the minimum necessary to reproduce.

tn...@google.com <tn...@google.com> Dec 22, 2022 05:50PM

Reassigned to tn...@google.com.

sg...@google.com <sg...@google.com> #4Jan 4, 2023 02:13PM

why is this marked has Obsolete? this is still a bug that is happening and its difficult to fix.
for all who are looking for a solution use this:

http://stackoverflow.com/questions/16200972/android-css-positionfixed-after-a-device-rotate

tn...@google.com <tn...@google.com> #5Jan 4, 2023 03:52PM

Marked as fixed.

I forgot to mark this bug when this was fixed last week, by this CL: https://cs.android.com/android-studio/platform/tools/base/+/125598ae3efac36da61631ad2e87a010ee064df5

It's fixed in Giraffe/8.1 but I think we should backport it to Flamingo/8.0 as well.

Søren, it sounds like you want to start desugaring these methods (good idea); maybe there should be a different tracking issue for that.

sg...@google.com <sg...@google.com> #6Jan 4, 2023 04:05PM

Thanks Tor. I have b/264405783 for tracking the desugaring. When done I will check that Lint no longer complaints. It should not, as the desugaring will tell Lint that these the close methods are new supported.

sa...@google.com <sa...@google.com> #7Jan 17, 2023 08:26PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Giraffe Canary 1 (2022.3.1.1)
Android Gradle Plugin 8.1.0

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!