TypedArray#close (API 31) not desugared but AS does not display warning when used in try-with-resources [262851206]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

Dec 17, 2022 01:43PM

Using: AS 2022.2.1 Canary 9, com.android.tools:desugar_jdk_libs:2.0.0, AGP 8.0.0-alpha09

Code below does not cause AS to show any warning that it is API 31+ only when TypedArray#close is invoked as part of a try-with-resources block:

	try (TypedArray array = ...) {
        {
        } // TypedArray#close implicitly called, crash on API < 31

In fact, an IDE intention suggested that I converted my classic use to TypedArray (that is, calling TypedArray#release after use) to a try-with-resources block, which I did (since I saw no API warning I assumed it was either desugared or properly handled for all API levels by D8) only to see it crash on API < 31.

It would be nice to have this call desugared or AS not suggesting to use try-with-resources on minApiSdk < 31 (which is probably pretty much all apps currently).

Comments

pu...@gmail.com <pu...@gmail.com> #2Dec 17, 2022 01:46PM

Will be this fix also part of 4.2 please?

ze...@google.com <ze...@google.com> Dec 19, 2022 08:11AM

Reassigned to cl...@google.com.

sg...@google.com <sg...@google.com> #3Dec 19, 2022 09:36AM

Reassigned to an...@google.com.

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

tn...@google.com <tn...@google.com> Dec 22, 2022 05:50PM

Reassigned to tn...@google.com.

sg...@google.com <sg...@google.com> #4Jan 4, 2023 02:13PM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

tn...@google.com <tn...@google.com> #5Jan 4, 2023 03:52PM

Marked as fixed.

Hello, this is a P1 S1 issue for a while now, and it's blocking us from upgrading to AGP 4.2 and further. What's the current status? And do you have plans to backport it to 4.2.x?

sg...@google.com <sg...@google.com> #6Jan 4, 2023 04:05PM

no we don't have a plan to backport this. why is this blocking you from upgrading ?

sa...@google.com <sa...@google.com> #7Jan 17, 2023 08:26PM

We sign apk's and bundles via internal service, and i don't know another way to interact with artifacts; Yesterday i ended up with some ugly workaround: https://github.com/avito-tech/avito-android/pull/1085/files#diff-b898cc20fedebe394439bb37ffb91d3366a1f9a6d359dbdebca79af8a079f911 I'd be glad if you'll point me out how can it be done better.