RememberPullRefreshState does not recompose with new offsets [263159832]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 20, 2022 10:21AM

Jetpack Compose version: 1.3.1 Jetpack Compose component used: androidx.compose.material:material

Android Studio Build: Build #AI-222.4345.14.2221.9321504, built on November 22, 2022

Kotlin version: 1.7.20

Steps to Reproduce or Code Sample to Reproduce:

Start with this example
Add a statusbar padding to the refreshingOffset & refreshTreshold (see code below)
See that the statusbar offsets are not handled.

It seems that insets are first laid out without any insets, the next composition gets the real insets. However as the pull to refresh state is being remembered the offset can never be updated. This causes the pull to refresh indicator to be below the statusbar in our case.

A workaround for now is getting the insets from the activity window insets, however this should not be the proper workaround.

Example code for adding statusbar padding:

    val state = rememberPullRefreshState(
            refreshing = viewState.showPullToRefreshLoader,
            onRefresh = viewModel::onPullToRefreshTriggered,
            refreshingOffset = PullRefreshDefaults.RefreshingOffset + WindowInsets.statusBars.asPaddingValues().calculateTopPadding(),
            refreshThreshold = PullRefreshDefaults.RefreshThreshold + WindowInsets.statusBars.asPaddingValues().calculateTopPadding()
           )

It seems to me that the pull to refresh state also needs to recompose on new offsets.

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3211381

Implement full screen search bar using dialog

Expand for full commit details

Implement full screen search bar using dialog 
 
Overview of new components: 
 * SearchBar - visually equivalent to previous overload, except does not 
   apply the padding/window insets of a top bar. 
 * CollapsedSearchBar - One half of SearchBar. Just a text field wrapped 
   in a Surface. 
 * FullScreenSearchBarLayout - private implementation. Equivalent to 
   existing SearchBarImpl + SearchBarLayout but slightly cleaned up. 
   Predictive back support will be added in future CL. 
 * ExpandedFullScreenSearchBar - FullScreenSearchBarLayout wrapped in a dialog. 
 
Bug: b/283311462 
Test: n/a 
Relnote: n/a 
Change-Id: I71145c5528a2c0c5ee97eca75dda0904ea91108b

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt

Hash: 7ccfa611287f4388caf0b0224b4b662e9a5f44af
Date: Tue Nov 19 22:59:52 2024

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3214040

Introduce SearchBarState

Expand for full commit details

Introduce SearchBarState 
 
This is part 1 of the search bar refactor. A new 
InputField overload has been added to use this state. 
Other component refactors will come in later CLs. 
 
Bug: b/283311462 
Test: n/a 
Relnote: n/a 
Change-Id: Ibb563b25de5ba76cec7612655b9b632c5f0e99d4

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt

Hash: 4f31090de77bee9f8e1e355e78125b8228e0985b
Date: Fri Aug 09 02:31:50 2024

Issue 263159832

Description

Issue summary

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

Add comment

Issue metadata