RememberPullRefreshState does not recompose with new offsets [263159832]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 20, 2022 10:21AM

Jetpack Compose version: 1.3.1 Jetpack Compose component used: androidx.compose.material:material

Android Studio Build: Build #AI-222.4345.14.2221.9321504, built on November 22, 2022

Kotlin version: 1.7.20

Steps to Reproduce or Code Sample to Reproduce:

Start with this example
Add a statusbar padding to the refreshingOffset & refreshTreshold (see code below)
See that the statusbar offsets are not handled.

It seems that insets are first laid out without any insets, the next composition gets the real insets. However as the pull to refresh state is being remembered the offset can never be updated. This causes the pull to refresh indicator to be below the statusbar in our case.

A workaround for now is getting the insets from the activity window insets, however this should not be the proper workaround.

Example code for adding statusbar padding:

    val state = rememberPullRefreshState(
            refreshing = viewState.showPullToRefreshLoader,
            onRefresh = viewModel::onPullToRefreshTriggered,
            refreshingOffset = PullRefreshDefaults.RefreshingOffset + WindowInsets.statusBars.asPaddingValues().calculateTopPadding(),
            refreshThreshold = PullRefreshDefaults.RefreshThreshold + WindowInsets.statusBars.asPaddingValues().calculateTopPadding()
           )

It seems to me that the pull to refresh state also needs to recompose on new offsets.

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

Marked as fixed.

Looks very similar to

https://issuetracker.google.com/issues/130561500tt

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

It seems like this could be addressed by updating the EnumType.parseValue() method, adding a fallback case in which if none of the enum values matches, then try to find a case insensitive match and return it.

maybe something like this?

public override fun parseValue(value: String): D {
    var caseInsensitiveMatch: D? = null
    for (constant in type.enumConstants) {
        val enumConstant = (constant as Enum<*>)
        if (enumConstant.name == value) {
            return constant
        }
        if (enumConstant.name.equals(value, ignoreCase = true) && caseInsensitiveMatch == null) {
            caseInsensitiveMatch = constant
        }
    }
    if (caseInsensitiveMatch != null) return caseInsensitiveMatch
    throw IllegalArgumentException(
        "Enum value $value not found for type ${type.name}."
    )
}

I'd be happy to submit a complete Pull Request if you think this is a good solution.

Issue 263159832

Description

Issue summary

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

Add comment

Issue metadata