RememberPullRefreshState does not recompose with new offsets [263159832]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 20, 2022 10:21AM

Jetpack Compose version: 1.3.1 Jetpack Compose component used: androidx.compose.material:material

Android Studio Build: Build #AI-222.4345.14.2221.9321504, built on November 22, 2022

Kotlin version: 1.7.20

Steps to Reproduce or Code Sample to Reproduce:

Start with this example
Add a statusbar padding to the refreshingOffset & refreshTreshold (see code below)
See that the statusbar offsets are not handled.

It seems that insets are first laid out without any insets, the next composition gets the real insets. However as the pull to refresh state is being remembered the offset can never be updated. This causes the pull to refresh indicator to be below the statusbar in our case.

A workaround for now is getting the insets from the activity window insets, however this should not be the proper workaround.

Example code for adding statusbar padding:

    val state = rememberPullRefreshState(
            refreshing = viewState.showPullToRefreshLoader,
            onRefresh = viewModel::onPullToRefreshTriggered,
            refreshingOffset = PullRefreshDefaults.RefreshingOffset + WindowInsets.statusBars.asPaddingValues().calculateTopPadding(),
            refreshThreshold = PullRefreshDefaults.RefreshThreshold + WindowInsets.statusBars.asPaddingValues().calculateTopPadding()
           )

It seems to me that the pull to refresh state also needs to recompose on new offsets.

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

Issue 263159832

Description

Issue summary

Comments

lp...@google.com <lp...@google.com> Dec 21, 2022 03:05PM

ap...@google.com <ap...@google.com> #2Dec 21, 2022 05:33PM

na...@google.com <na...@google.com> #3Jan 11, 2023 08:11PM

Add comment

Issue metadata