Updating bottom padding of PaddingValues and then passing it to LazyColumn(contentPadding = ...) sometimes does not recompose the lambda inside of rememberLazyListMeasurePolicy() [263402091]

Fixed

Bug

Status Update

No update yet.

Description

ke...@gmail.com

created issue #1

Dec 22, 2022 07:02AM

Jetpack Compose version: 1.4.0-alpha03

Jetpack Compose component(s) used: LazyColumn

Android Studio Build: Android Studio Electric Eel | 2022.1.1 RC 1

Kotlin version: 1.7.20

Originally, I asked this question on #compose slack channel but I was asked to report it here.

"Hi. I'm currently using Compose 1.4.0-alpha03 and I'm experiencing a weird behavior where updating bottom padding of PaddingValue which is then passed to LazyColumn(contentPadding = ...) doesn't actually use the new padding inside of the rememberLazyListMeasurePolicy. The bottom padding is updated with the keyboard height everytime it appears/disappears. I'm placing two breakpoints 1. Inside of the internal fun LazyList(...) function on state.placementAnimator = placementAnimator line. 2. Inside of the private fun rememberLazyListMeasurePolicy() function on checkScrollableContainerConstraints() line. Then I'm clicking a textfield to make the keyboard appear. Once the first breakpoint is hit I first check that the bottom padding is the value I'm expecting to see (~300dp) then I place a new breakpoint inside of PaddingValuesImpl.equals() method. Then I resume the app, PaddingValuesImpl.equals() is getting called a couple of times but it's called not from the place I'm expecting it to get called from. I'm expecting a call from remember<LazyLayoutMeasureScope.(Constraints) -> MeasureResult>() { ... } line which is in rememberLazyListMeasurePolicy() method but it never gets called from that method. Then the second breakpoint which is on checkScrollableContainerConstraints() line is getting hit and when I check the contentPadding I'm seeing the old value (24dp). So I'm assuming that the remember<LazyLayoutMeasureScope.(Constraints) -> MeasureResult>() { ... } doesn't work for some reason in this situation so the lambda is not re-remebered in other words it's the previous lambda that captured the previous contentPadding. I would really like to see what's going on inside remember<LazyLayoutMeasureScope.(Constraints) -> MeasureResult>() { ... } but I can't place a breakpoint there because it tells me to download the source code and when I click download it can't find it. I tried installing the compose-runtime dependency but it still won't show me the source code of that remember<LazyLayoutMeasureScope.(Constraints) -> MeasureResult>() { ... } function. This feels like a bug in that one remember function. However I also tried to create a new project and copy some of the code to try and reproduce the issue but it works just fine there (same compose version). So I'm kinda lost now. I'm not sure I should report this on the issue tracker because I have no MRE and it also works in a new test project but doesn't work in the main project. The app I'm developing is open-source so I can provide the whole project if needed."

STR:

Clone this branch: https://github.com/K1rakishou/KurobaExLite/tree/lazycolumn_remember_weird_behavior
Click "Select a catalog" text in the toolbar.
Scroll to the very bottom (100th item).
Click the "Search" icon.
Keyboard will show up. Scroll to bottom again you will see that it can't scroll past ~94th item.

If you do the steps described above (the one with breakpoints) you will see the bug. I'm also attaching a video where I'm doing those steps.

As I have already said above I tried to create a MRE in a new project but was surprised to see that it works there flawlessly. Also I have multiple places in this project where I'm using the same method to set the bottom padding of the LazyColumn when the keyboard shows up and it works in some of those places.

studio64_MvsnAZTM9k.mp4

11 MB

Download

Comments

ma...@google.com <ma...@google.com> Dec 22, 2022 10:56AM

Reassigned to as...@google.com.

as...@google.com <as...@google.com> #2Dec 23, 2022 03:21AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

Message last modified on Dec 23, 2022 03:22AM

ke...@gmail.com <ke...@gmail.com> #3Dec 23, 2022 04:23AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

as...@google.com <as...@google.com> #4Dec 29, 2022 07:34PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

Message last modified on Dec 29, 2022 07:43PM

as...@google.com <as...@google.com> #5Dec 29, 2022 08:34PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

Message last modified on Jan 5, 2023 08:51PM

as...@google.com <as...@google.com> #6Dec 29, 2022 08:36PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ap...@google.com <ap...@google.com> #7Oct 17, 2023 01:43PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

ap...@google.com <ap...@google.com> #8Nov 9, 2023 02:54PM

Thank you, I'll try it and check.

al...@google.com <al...@google.com> #9Mar 14, 2024 07:54PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.

as...@google.com <as...@google.com> #10Mar 14, 2024 07:57PM

Marked as fixed.

Also I found there is a post which presents same issue on stackoverflow.

https://stackoverflow.com/questions/68832304/mlkit-translate-sdk-crashes-in-release-build