Some NavController#navigate overloads not annotated with @MainThread [263427111]

Fixed

Bug

Status Update

No update yet.

Description

jo...@jossiwolf.de

created issue #1

Dec 23, 2022 12:21AM

Component used: Navigation Version used: 2.5.0-SNAPSHOT

Looks like the @MainThread annotation is missing on these two overloads. Should it be added?

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt;l=2020;drc=f433d5458950a632900f8a2685ce6eab27272f8c

Comments

jb...@google.com <jb...@google.com> Dec 27, 2022 04:31PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Feb 9, 2023 11:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 50d237e27be6f5ec9dff98af90910ef65fae9f08
Author: Clara Fok <clarafok@google.com>
Date: Tue Feb 07 16:39:21 2023

Annotate NavController#navigate with MainThread

Test: n/a
Bug: 263427111
Relnote: "All NavController#navigate overloads are now annotated with @MainThread to ensure that they are called on main thread."
Change-Id: I2c0b03cf115708fd40d0eee6359bae7302141105

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2425402

jo...@gmail.com <jo...@gmail.com> #3Feb 9, 2023 11:12PM

Ty!!

cl...@google.com <cl...@google.com> #4Feb 9, 2023 11:37PM

Marked as fixed.

This has been fixed internally and will be available in navigation 2.6.0-alpha06

na...@google.com <na...@google.com> #5Feb 22, 2023 07:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-runtime:2.6.0-alpha06

Issue 263427111