Cannot type @ (conflict from logcat shortcut) [263475910]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Dec 23, 2022 01:22PM

Build: AI-222.4459.24.2221.9409768, 202212151943, 

AI-222.4459.24.2221.9409768, JRE 17.0.4.1+0-17.0.4.1b469.62-9127311x64 JetBrains s.r.o., OS Mac OS X(x86_64) v12.6.2, screens 3584.0x2240.0; Retina

AS: Flamingo | 2022.2.1 Canary 10
Kotlin plugin: 222-1.7.21-release-AS3739.54
Android Gradle Plugin: 7.0.4
Gradle: 7.1.1
Gradle JDK: version 17.0.4
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)


IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

In Text Editor it is not possible to type an @ with the default shortcut

Comments

vi...@google.com <vi...@google.com> #2Dec 26, 2022 05:57AM

The issue is that Jetifier modifies jars and does not remove signatures. Below is the original class:

Classfile /tmp/non-jetified/org/bouncycastle/jce/provider/ExtCRLException.class
Last modified Mar 1, 2015; size 362 bytes
MD5 checksum 3968a716f9e60e1ad36c34157bd0239f
class org.bouncycastle.jce.provider.ExtCRLException extends java.security.cert.CRLException
minor version: 0
major version: 49
flags: ACC_SUPER
Constant pool:
#1 = Utf8 <init>
#2 = Utf8 cause
#3 = Utf8 getCause
#4 = Utf8 java/security/cert/CRLException
#5 = Utf8 org/bouncycastle/jce/provider/ExtCRLException
#6 = Class #4 // java/security/cert/CRLException
#7 = Class #5 // org/bouncycastle/jce/provider/ExtCRLException
#8 = Utf8 Ljava/lang/Throwable;
#9 = Utf8 (Ljava/lang/String;)V
#10 = Utf8 ()Ljava/lang/Throwable;
#11 = Utf8 (Ljava/lang/String;Ljava/lang/Throwable;)V
#12 = NameAndType #2:#8 // cause:Ljava/lang/Throwable;
#13 = NameAndType #1:#9 // "<init>":(Ljava/lang/String;)V
#14 = Fieldref #7.#12 // org/bouncycastle/jce/provider/ExtCRLException.cause:Ljava/lang/Throwable;
#15 = Methodref #6.#13 // java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
#16 = Utf8 Code
{
java.lang.Throwable cause;
descriptor: Ljava/lang/Throwable;
flags:

org.bouncycastle.jce.provider.ExtCRLException(java.lang.String, java.lang.Throwable);
descriptor: (Ljava/lang/String;Ljava/lang/Throwable;)V
flags:
Code:
stack=2, locals=3, args_size=3
0: aload_0
1: aload_1
2: invokespecial #15 // Method java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
5: aload_0
6: aload_2
7: putfield #14 // Field cause:Ljava/lang/Throwable;
10: return

public java.lang.Throwable getCause();
descriptor: ()Ljava/lang/Throwable;
flags: ACC_PUBLIC
Code:
stack=1, locals=1, args_size=1
0: aload_0
1: getfield #14 // Field cause:Ljava/lang/Throwable;
4: areturn
}

One processed with Jetifier:

Classfile /tmp/jetified/org/bouncycastle/jce/provider/ExtCRLException.class
Last modified Oct 14, 2019; size 362 bytes
MD5 checksum 76bc557706ee3480e53d88b21316913f
class org.bouncycastle.jce.provider.ExtCRLException extends java.security.cert.CRLException
minor version: 0
major version: 49
flags: ACC_SUPER
Constant pool:
#1 = Utf8 org/bouncycastle/jce/provider/ExtCRLException
#2 = Class #1 // org/bouncycastle/jce/provider/ExtCRLException
#3 = Utf8 java/security/cert/CRLException
#4 = Class #3 // java/security/cert/CRLException
#5 = Utf8 cause
#6 = Utf8 Ljava/lang/Throwable;
#7 = Utf8 <init>
#8 = Utf8 (Ljava/lang/String;Ljava/lang/Throwable;)V
#9 = Utf8 (Ljava/lang/String;)V
#10 = NameAndType #7:#9 // "<init>":(Ljava/lang/String;)V
#11 = Methodref #4.#10 // java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
#12 = NameAndType #5:#6 // cause:Ljava/lang/Throwable;
#13 = Fieldref #2.#12 // org/bouncycastle/jce/provider/ExtCRLException.cause:Ljava/lang/Throwable;
#14 = Utf8 getCause
#15 = Utf8 ()Ljava/lang/Throwable;
#16 = Utf8 Code
{
java.lang.Throwable cause;
descriptor: Ljava/lang/Throwable;
flags:

org.bouncycastle.jce.provider.ExtCRLException(java.lang.String, java.lang.Throwable);
descriptor: (Ljava/lang/String;Ljava/lang/Throwable;)V
flags:
Code:
stack=2, locals=3, args_size=3
0: aload_0
1: aload_1
2: invokespecial #11 // Method java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
5: aload_0
6: aload_2
7: putfield #13 // Field cause:Ljava/lang/Throwable;
10: return

public java.lang.Throwable getCause();
descriptor: ()Ljava/lang/Throwable;
flags: ACC_PUBLIC
Code:
stack=1, locals=1, args_size=1
0: aload_0
1: getfield #13 // Field cause:Ljava/lang/Throwable;
4: areturn
}

Changes in the constants pool cause changes in the code (indices change), which causes different MD5 checksums. This means that signatures will not match any more.

This started happening in 3.6.0-beta01 because we are using Jetifier with copyUnmodifiedLibsAlso=true flag (previously it was false).

ma...@gmail.com <ma...@gmail.com> #3Dec 26, 2022 08:04AM

@Chris You can work around this by updating gradle.properties with:

android.jetifier.blacklist=.*bcprov.*

This will avoid Jetifying the bouncycastle library.

Message last modified on Dec 26, 2022 09:56AM

Screen Recording 2022-12-26 at 09.01.42.mov

2.8 MB

Download

idea.log

597 KB

View

Download

ma...@gmail.com <ma...@gmail.com> #4Dec 27, 2022 10:00AM

Thanks Ivan!

Tue Dec 27 2022 10:59:31 GMT+0100 (Central European Standard Time).png

22 KB

View

Download

vs...@google.com <vs...@google.com> Dec 28, 2022 09:28PM

Assigned to an...@google.com.

aa...@google.com <aa...@google.com> #5Dec 28, 2022 10:34PM

Reassigned to ad...@google.com.

Pending fix in:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1151460

aa...@google.com <aa...@google.com> #6Dec 28, 2022 10:34PM

did this fix make it in for 3.6?

ad...@google.com <ad...@google.com> #7Dec 28, 2022 10:39PM

Jetifier 1.0.0-beta08 was released and has a fix for this.

To avoid waiting for new Android Studio you can workaround this in the meantime by forcing usage of a new version of jetifier in gradle:
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:x.y.z'
classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta08' // <- Add this
}
}

Message last modified on Dec 28, 2022 10:44PM

aa...@google.com <aa...@google.com> #8Dec 28, 2022 10:49PM

Jetifier 1.0.0-beta08, which has the fix for this issue, will be integrated into AGP 3.6.0-rc01 and 4.0.0-alpha06:

https://android.googlesource.com/platform/tools/base/+/ef5e56702b626b6be642ecce7d0078b7b1a81bcb

Message last modified on Dec 28, 2022 10:49PM

ad...@google.com <ad...@google.com> #9Jan 6, 2023 08:28PM

Reassigned to am...@google.com.

I'm hesitant to change the default binding because it might result in conflicting with some other layout. IntelliJ and Android Studio is currently not localized and is offered only in English. HAving said that, it seems like the clear workaround is to either remove the existing key binding or remap to something else that works.

ad...@google.com <ad...@google.com> #10Jan 6, 2023 08:29PM

@amy, do you think this is worth documenting somewhere?

am...@google.com <am...@google.com> #11Jan 7, 2023 12:01AM

Yes, I can document this on the logcat and known issues pages. Will am to send a CL by the end of next week. Thanks for looping me in!

yi...@googlemail.com <yi...@googlemail.com> #12Jan 15, 2023 07:20PM

This issue is also in Electric Eel, please change that for mac. It is stopping me from coding annotation such as compose code, very annoying. If not, make the short cut deactivable.

Please see issue 265528494. This shall be a p1 issue, which makes AS Studio useless.

Message last modified on Jan 15, 2023 07:26PM

yi...@googlemail.com <yi...@googlemail.com> #13Jan 15, 2023 07:23PM

Is there a work round? Any hints are really appreciated.

yi...@googlemail.com <yi...@googlemail.com> #14Jan 15, 2023 07:49PM

The workaround works for me now, thanks to #4 I made a detailed description to remove the keymap for "alt" + "L" on mac at https://stackoverflow.com/a/75127936/3569768

aa...@google.com <aa...@google.com> Jan 17, 2023 04:28PM

Reassigned to ad...@google.com.

aa...@google.com <aa...@google.com> Jan 26, 2023 05:37PM

Marked as fixed.

r....@gmail.com <r....@gmail.com> Feb 11, 2023 08:37AM

idea.log.txt

597 KB

View

Download

IssueTracker