Status Update
No update yet.
Comments
vi...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ma...@gmail.com
ma...@gmail.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
vs...@google.com
aa...@google.com
I can't repro on Linux. This might be a general IntelliJ shortcut system issue.
The shortcut mentioned in Option-L, Option-F which isn't anywhere near @. Additionally, the shortcut is only supposed to active inside the Logcat tool window.
That said, I suppose I could change the shortcut to something else on Mac's. I don't have a Mac so I can't test this nor can I check if any shortcut I choose will be in conflict with something.
aa...@google.com
Adarsh, please advise
ad...@google.com
The video shows that a non-English keyboard layout is being used (I believe it's German given the autocompletions). This relocates the @ symbol onto the L key such that ⌥L will type an @.
Given how macOS allows typing special characters, I assume this is a Mac-only issue. I also suspect any other keyboard shortcuts that start with ⌥ will produce the same behavior.
aa...@google.com
Hmm, so I'm looking for other Alt- bindings on my Linux and I can see a few:
Alt-Q->Context infoAlt-J->Add selection for Next OccurrenceAlt-O->Export ResultsAlt-M->Amend Commit
Does this happen for these too? If not, what are these actions bound to on Mac?
ad...@google.com
I'm hesitant to change the default binding because it might result in conflicting with some other layout. IntelliJ and Android Studio is currently not localized and is offered only in English. HAving said that, it seems like the clear workaround is to either remove the existing key binding or remap to something else that works.
ad...@google.com
@amy, do you think this is worth documenting somewhere?
am...@google.com
Yes, I can document this on the logcat and known issues pages. Will am to send a CL by the end of next week. Thanks for looping me in!
yi...@googlemail.com
This issue is also in Electric Eel, please change that for mac. It is stopping me from coding annotation such as compose code, very annoying. If not, make the short cut deactivable.
Please see
yi...@googlemail.com
Is there a work round? Any hints are really appreciated.
yi...@googlemail.com
The workaround works for me now, thanks to #4
I made a detailed description to remove the keymap for "alt" + "L" on mac at
Description
In Text Editor it is not possible to type an @ with the default shortcut