KGP reads manifest during configuration, invalidating configuration cache on manifest change [263575963]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Dec 23, 2022 04:00PM

Using the attached project, and running ./gradlew help --configuration-cache generates output that looks like:

See the complete report at file:///usr/local/google/home/gavra/AndroidStudioProjects/agp_r8_issue/build/reports/configuration-cache/9wxp91p2vo4elheo9l878on3/cp5w42eqidvt9dg0devnkz56f/configuration-cache-report.html

Opening the HTML report shows that kotlin-android plugin reads AndroidManifest.xml, causing configuration cache to be invalidated when manifest changes (see attachment).

Note that the project is using org.gradle.internal.instrumentation.agent=true property that triggers this detection.

cc_input.zip

834 KB

Download

Fri Dec 23 2022 16:00:21 GMT+0000 (Greenwich Mean Time).png

44 KB

View

Download

Comments

ga...@google.com <ga...@google.com> #2Dec 23, 2022 04:36PM

It seems like AGP accesses app/src/androidTestDebug/AndroidManifest.xml, so we should also investigate that (see the Build configuration inputs tab in the HTML report).

Gradle Configuration Cache.html

172 KB

View

Download

hu...@google.com <hu...@google.com> #3Jan 6, 2023 01:45PM

Marked as fixed.

We've fixed AGP access to the manifests, the KGP access is actually caused by the AGP access (KGP calling into AGP): https://android.googlesource.com/platform/tools/base/+/1dd6caab099e8156adf63ae7f4040c4727920653

sh...@gmail.com <sh...@gmail.com> #4Apr 23, 2023 01:11AM

Thank you!

Issue 263575963

Description

Issue summary

Comments

ga...@google.com <ga...@google.com> #2Dec 23, 2022 04:36PM

hu...@google.com <hu...@google.com> #3Jan 6, 2023 01:45PM

sh...@gmail.com <sh...@gmail.com> #4Apr 23, 2023 01:11AM

Add comment

Issue metadata