`com.android.build.gradle.tasks.ShaderCompile` issues with configuration cache [263576736]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Dec 23, 2022 04:25PM

Using the attache project and running gw comDeSha --configuration-cache fails with

org.gradle.api.InvalidUserCodeException: Invocation of 'Task.project' by task ':app:compileDebugShaders' at execution time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onTaskExecutionAccessProblem(ConfigurationCacheProblemsListener.kt:101)
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onProjectAccess(ConfigurationCacheProblemsListener.kt:64)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:460)
	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:442)
	at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:83)
	at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:69)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast$ListenerDispatch.dispatch(DefaultListenerManager.java:431)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast.dispatch(DefaultListenerManager.java:219)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast.dispatch(DefaultListenerManager.java:190)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at jdk.proxy1/jdk.proxy1.$Proxy103.onProjectAccess(Unknown Source)
	at org.gradle.configurationcache.AbstractTaskProjectAccessChecker.notifyProjectAccess(TaskExecutionAccessCheckers.kt:29)
	at org.gradle.api.internal.AbstractTask.getProject(AbstractTask.java:239)
	at org.gradle.api.DefaultTask.getProject(DefaultTask.java:59)
	at com.android.build.gradle.tasks.ShaderCompile.getSourceFiles(ShaderCompile.java:113)

We should not use Task.project.

shaders.zip

1 MB

Download

Comments

ga...@google.com <ga...@google.com> #2Dec 23, 2022 04:34PM

Using the same project, and running gw asDeb --configuration-cache generates an HTML report (like e.g. file:///usr/local/google/home/gavra/AndroidStudioProjects/agp_r8_issue/build/reports/configuration-cache/71bxgz42iqmeflkzkeiz07rgj/exur7n03273b7z2r0b8e1z25h/configuration-cache-report.html), which indicates that ShaderCompile reads app/build/intermediates/merged_shaders/debug/out at configuration time.

The issue is

@InputFiles
    @IgnoreEmptyDirectories
    @PathSensitive(PathSensitivity.RELATIVE)
    @SkipWhenEmpty
    public FileTree getSourceFiles() {
        File sourceDirFile = getSourceDir().get().getAsFile();
        FileTree src = null;
        if (sourceDirFile.isDirectory()) {
            src = getProject().files(sourceDirFile).getAsFileTree().matching(PATTERN_SET);
        }
        return src == null ? getProject().files().getAsFileTree() : src;
    }

which should migrate to Provider.map {}.

Fri Dec 23 2022 16:33:03 GMT+0000 (Greenwich Mean Time).png

7.1 KB

View

Download

je...@google.com <je...@google.com> Jan 3, 2023 10:10PM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> Jan 4, 2023 07:12PM

Marked as fixed.

sa...@google.com <sa...@google.com> #3Jan 17, 2023 08:26PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Giraffe Canary 1 (2022.3.1.1)
Android Gradle Plugin 8.1.0

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ra...@gmail.com <ra...@gmail.com> #4Jan 29, 2023 04:53AM

2055-2

mn...@gmail.com <mn...@gmail.com> #5Feb 4, 2023 05:47AM

Please my app launch

em...@gmail.com <em...@gmail.com> #6Sep 27, 2023 10:34AM