Jpeg image corruption if writing location after updating some Exif attributes [263747161]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Dec 27, 2022 02:07AM

Component used: Version used: Devices/Android versions reproduced on: Samsung A32 (sm-a325f) Android 12 (also A12/A13 mentioned in b/263289024)

When reporting bugs, please always include:

A full bug report as an attachment, captured during or shortly after experiencing the issue.

Bugreport on Samsung sm-a325f:

About 17:41 Install and launch the first test app to run with self-copy-exif and write-location-data on

About 17:42 Install and launch the second test app to take a picture

Reproduction steps, being as specific as possible.

I’m working for the CameraX project and one Exif location related issue (b/263289024) was reported. The issue seems like that can be reproduced on specific Samsung Android 12 devices (A13, A32, A12). I can reproduce the issue on a Samsung A32 (sm-a325f) Android device. After some investigation, I wrote a sample app which can reproduce the issue.

i. Please refer to the sample project in the attached MyApplication-ExifLocationIssue.zip. I use CameraX to capture a JPEG image on a Samsung A32 device and use it (put in the project assets folder) to reproduce the issue. Please compile and run the sample app to check the following cases and results: (This can be run on any device)

Self copy Exif Write location data Decode result file

Yes Yes Failed

Yes No Passed

No Yes Passed

Yes No Passed

ii. I don’t know what affects the test results. When using the above sample app, no matter which location provider data is set, the issue can be reproduced. But if I set the location data by CameraXBasic sample app just as what is reported in b/263289024. The issue only happens if the location data is specified as LocationManager#FUSED_PROVIDER data. The issue won’t happen when setting it as LocationManager#GPS_PROVIDER data. Please compile the attached CameraXBasic-WriteFusedLocation.zip and modify the location provider setting in the CameraFragment.kt to check the results. (This can be run on the problematically devices)

Self copy Exif	Write location data	Decode result file
Yes	Yes	Failed
Yes	No	Passed
No	Yes	Passed
Yes	No	Passed

How reproducible the issue is on the affected device.

100% on Samsung A32 (sm-a325f) Android 12 device

If known, how reproducible the issue is on other devices and OS versions.

Where possible, please also provide:

A sample project that reproduces the issue.

Please see the attached sample apps

A screenrecord or screenshots showing the issue.

dumpstate-2022-12-26-17-43-03.zip

13 MB

Download

deleted

Restricted+

0 B

CameraXBasic-WriteFusedLocation.zip

680 KB

Download

Comments

ap...@google.com <ap...@google.com> #2Jan 3, 2023 03:18AM

I have unintentionally posted this as a bug but it is a Feature Request instead. Please change the category, thank you.

ib...@google.com <ib...@google.com> #3Mar 6, 2023 01:53PM

Thanks for filing this - I've changed it to a Feature request and marked it for our team to look at for Video development. Thanks!

ib...@google.com <ib...@google.com> #4Mar 6, 2023 04:04PM

Hi, we're heavily using CameraX API for recording video and this is much anticipated feature for us. Is there any timeframe for this issue? Thanks

ib...@google.com <ib...@google.com> #5Mar 6, 2023 04:17PM

Hi, it is expected to release the first alpha soon. This feature is in our current roadmap, but we are not able to provide an exact timeframe to support this feature. Please stay tuned. Thanks!

ib...@google.com <ib...@google.com> #6Mar 6, 2023 04:23PM

Hi, seems like the latest alpha doesn't have the changes, does it?

ib...@google.com <ib...@google.com> #7Mar 6, 2023 04:54PM

Yes, the first video capture library doesn't support mirror/non-mirror output, but it's in our pipeline. :)

ch...@google.com <ch...@google.com> #8Mar 7, 2023 10:00AM

Hi, are there any updates?

ib...@google.com <ib...@google.com> #9Mar 7, 2023 10:07AM

Hi there,

Thanks for the question - I've added this to our 1.2 candidate list so we'll be working on it. Note: We're going to be releasing 1.1 beta soon, then following the sem-versioning of 1.1 RC, 1.1 Stable, then proceeding to 1.2 branch. We hope the process with go more quickly this year. Thanks!

ib...@google.com <ib...@google.com> #10Mar 7, 2023 02:09PM

+1 for this feature

ap...@google.com <ap...@google.com> #11Mar 7, 2023 04:16PM

Hi there, any update on this?

ib...@google.com <ib...@google.com> Mar 7, 2023 04:16PM

Marked as fixed.

mw...@gmail.com <mw...@gmail.com> #12Mar 7, 2023 05:51PM

Hi,

We are currently working on this feature and it is high priority. Stay tuned!

ib...@google.com <ib...@google.com> #13Mar 7, 2023 05:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4e979f702d053727557118464e0fb5ae4df9220f
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 18:04:22 2023

Apply mirror mode to VideoCapture, Preview and StreamSharing

- For Preview, MIRROR_MODE_FRONT_ON is the default value and can not be changed.
- For VideoCapture, add getMirrorMode()/Builder.setMirrorMode() which will be exposed later.
- For StreamSharing, VirtualCamera refers to UseCase mirror mode when generating child SurfaceProcessorNode.OutConfig.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: I674c7bdf8b0516cefe298090549f5e22882cfddb

M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/processing/SurfaceProcessorNode.java
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/VirtualCamera.java
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/VirtualCameraTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463056

na...@google.com <na...@google.com> #14Dec 13, 2023 06:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c78e313a38f1fee57742af743ad1fbb628255e9
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 16:01:29 2023

Add MirrorMode and apply to UseCases

- API design go/camerax-videocapture-mirroring
- The default mirror mode is MIRROR_MODE_OFF.
- Throw UnsupportedOperationException to Builder.setMirrorMode() by default.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: If5128439c48b4b226c7fe6b8a6e6bcb516f16804

M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/MirrorMode.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageOutputConfig.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageAnalysisTest.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageCaptureTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeUseCaseConfig.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463055

na...@google.com <na...@google.com> #15Nov 13, 2024 06:19PM

Hello, are there any updates on when this is going live? Thank you