IssueTracker

If the array of choices for MultiSelectListPreference is changed, the previous stored selections in preferences can't be seen nor removed by the user. The result for the user may be that the app settings are different then what they appear to be.

---

I wrote a MultiSelectListPreference in xml as follows and used it in a PreferenceFragmentCompat:

<PreferenceCategory app:title="experiment">
    <MultiSelectListPreference
        app:key="experiment"
        app:entries="@array/abc"
        app:entryValues="@array/abc"
        app:title="my values test"
        />
</PreferenceCategory>

And the array is

<array name="abc">
    <item>a</item>
    <item>b</item>
    <item>c</item>
</array>

When in the UI selecting all choices, the result in preferences file is

<set name="experiment">
    <string>a</string>
    <string>b</string>
    <string>c</string>
</set>

Now changing the array to be

<array name="abc">
    <item>A</item>
    <item>B</item>
    <item>C</item>
</array>

and going to preferences UI again. The user sees only the new choices, and if selecting all choices the resulting preferences file is

<set name="experiment">
    <string>a</string>
    <string>A</string>
    <string>b</string>
    <string>B</string>
    <string>c</string>
    <string>C</string>
</set>

And if deselecting all choices the result is again

<set name="experiment">
    <string>a</string>
    <string>b</string>
    <string>c</string>
</set>

The user has no way to clear the old selected values.

(In my real case, the arrays are set on runtime and made from phone contacts, so they can change when contacts change.)

It looks to me like a bug. I would expect that after the user changes selections, the saved preferences would contain only choices the user sees.

Workaround:

Add to the arrays the existing saved values which are not in the new arrays. Then the user can deselect them (or keep them). If the user deselects the old values, they will not appear next time.

In override of PreferenceFragmentCompat : onCreatePreferences

val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context)
val oldValues = sharedPreferences.getStringSet("experiment",  emptySet<String>())
if (oldValues != null) {
   val onlyOldValues = oldValues.toMutableSet()
   onlyOldValues.removeAll(entryValues.toSet())
   entryValues += onlyOldValues
   entries += onlyOldValues
}